Merge _gen_multiple into _gen_with_multiple_nodes #3245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This diff ensures that gen_with_multiple_nodes can function independently by removing the call to _gen_mutliple(..). This sets us up to fully reap _gen_multiple in a future diff (when we simeltanously replace calls to _gen_multiple with _gen_for_multiple_trials_with_multiple_modesl(..) in diff 4/n
Internal
-
Tldr:
{F1973912725}
See diff 1/n in the stack for context
Reviewed By: lena-kashtelyan
Differential Revision: D67315146
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67315146 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 17, 2025
Summary:
This diff ensures that gen_with_multiple_nodes can function independently by removing the call to _gen_mutliple(..). This sets us up to fully reap _gen_multiple in a future diff (when we simeltanously replace calls to _gen_multiple with _gen_for_multiple_trials_with_multiple_modesl(..) in diff 4/n
Internal
-
Tldr:
{F1973912725}
See diff 1/n in the stack for context
Reviewed By: lena-kashtelyan
Differential Revision: D67315146
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
==========================================
- Coverage 95.88% 95.87% -0.01%
==========================================
Files 513 513
Lines 51677 51687 +10
==========================================
+ Hits 49550 49555 +5
- Misses 2127 2132 +5 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in b4aa11b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff ensures that gen_with_multiple_nodes can function independently by removing the call to _gen_mutliple(..). This sets us up to fully reap _gen_multiple in a future diff (when we simeltanously replace calls to _gen_multiple with _gen_for_multiple_trials_with_multiple_modesl(..) in diff 4/n
Internal
Tldr:
{F1973912725}
See diff 1/n in the stack for context
Reviewed By: lena-kashtelyan
Differential Revision: D67315146