use most recent trial in TransformToNewSQ by default #3225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67875128 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 513 513
Lines 51710 51723 +13
=======================================
+ Hits 49579 49592 +13
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
sdaulton
force-pushed
the
export-D67875128
branch
from
4b88d90 to
3d5d17f
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 16, 2025
…wSQ (facebook#3225) Summary: see title. This ensures that status_quo_data_by_trial contains the target trial index by default. Differential Revision: D67875128
|
This pull request was exported from Phabricator. Differential Revision: D67875128 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 16, 2025
…wSQ (facebook#3225) Summary: see title. This ensures that status_quo_data_by_trial contains the target trial index by default. Differential Revision: D67875128
sdaulton
force-pushed
the
export-D67875128
branch
from
3d5d17f to
f88252d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67875128 |
…wSQ (facebook#3225) Summary: see title. This ensures that status_quo_data_by_trial contains the target trial index by default. Reviewed By: danielcohenlive Differential Revision: D67875128
sdaulton
force-pushed
the
export-D67875128
branch
from
f88252d to
f6a09b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67875128 |
|
This pull request has been merged in e29e8ba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title. This ensures that status_quo_data_by_trial contains the target trial index by default.
Differential Revision: D67875128