add examples for migration v5 #1712
Merged
+179
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
requires-translation-fr
requires-translation-es
requires-translation-it
requires-translation-ja
requires-translation-ko
requires-translation-pt-br
requires-translation-ru
requires-translation-sk
requires-translation-th
requires-translation-tr
requires-translation-uk
requires-translation-uz
requires-translation-zh-cn
requires-translation-zh-tw
requires-translation-id
labels
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjohansebas
force-pushed
the
examples-in-migration
branch
from
e4f794e to
a6c2f37
Compare
bjohansebas
commented
Dec 10, 2024
en/guide/migrating-5.md
Outdated
| ``` | ||
|
|
||
| {% capture note_wildcard %} | ||
| If your defined route is `/*splat`, it will not include `/`, so you will need to make the route optional. |
There was a problem hiding this comment.
@blakeembrey
Is this wording correct? It’s a recurring problem i’ve seen, which is why I wanted to add that note, but I’m not sure if this is the best phrasing.
There was a problem hiding this comment.
so you will need to make the route optional.
I am not sure I follow what you are saying here. Is it not enough to just end that sentence after the first part?
There was a problem hiding this comment.
@wesleytodd I changed the phrasing a bit, I think it’s clearer now.
*splatmatches any path without the root path. If you need to match the root path as well/, you can use/{*splat}, wrapping the wildcard in braces.
wesleytodd
approved these changes
Jan 8, 2025
bjohansebas
force-pushed
the
examples-in-migration
branch
from
a6c2f37 to
7452886
Compare
UlisesGascon
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples are added for better understanding of the changes that were made; this was an idea that came from #1705.