feat: don't compress on x-no-compression header #208
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamLizu
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
function shouldCompress (req, res) {
var type = res.getHeader('Content-Type')
var noCompressionHeader = res.getHeader('x-no-compression')
if (noCompressionHeader) {
debug('%s not compressed', type)
return false
}
if (type === undefined || !compressible(type)) {
debug('%s not compressible', type)
return false
}
return true
}PS: I don't know why but I am not seeing the commit suggestion feature right now, so I have given the code in comment.
index.js
Outdated
| @@ -256,12 +256,18 @@ function chunkLength (chunk, encoding) { | |||
|
|
|||
| function shouldCompress (req, res) { | |||
| var type = res.getHeader('Content-Type') | |||
| var noCompressionHeader = res.getHeader('x-no-compression') | |||
|
|
|||
| if (type === undefined || !compressible(type)) { | |||
There was a problem hiding this comment.
compressible is being called even if added noCompressionHeader is present. noCompressionHeader should be checked first.
bjohansebas
force-pushed
the
x-no-compression
branch
from
7a4b75e to
79cdf57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should observe when
X-No-Compressionis sent in the request.