Allow for selection of the previous two previous versions of the Gradle Enterprise Maven Extension #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension applications
clayburn
force-pushed
the
cj/multiple_ge_mvn_extensions
branch
from
79048d3 to
5c058ee
Compare
clayburn
commented
Jun 6, 2023
| @@ -30,6 +34,8 @@ dependencies { | |||
|
|
|||
| processResources { | |||
| from configurations.mvnExtensions | |||
| from configurations.geMvnExtensionOnePrevious | |||
| from configurations.geMvnExtensionTwoPrevious | |||
There was a problem hiding this comment.
This PR (not just this line) increase the complexity of managing the extension versions in this repository. I see two issues:
- I expect Dependabot to try to update these two lines to the most recent versions of Gradle Enterprise Maven Extension every time a new release occurs. We could either disable Dependabot for the agent and lost the benefits for all other dependencies, or ensure Dependabot PRs for these two lines are not merged. Both feel problematic.
- This just adds more places where we need to manually update version numbers on updates to the Gradle Enterprise Maven Extension that are not covered by Dependabot. See other references to versions present in this PR. I'd be interested in discussing a solution to this issue at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the user to select the most recent patch version of the previous two releases of the Gradle Enterprise Maven Extension. For example, as of today where 1.17.3 is the most recent release, 1.15.5 and 1.16.6 are also selectable. This is achieved by bundling all 3 versions of the extension into the agent jar.
This is enforced at the connection UI with a dropdown. By default the dropdown has an empty value selected, but the user can change this to any of the three bundled versions of the Gradle Enterprise Maven Extension.
Since the Common Custom User Data Maven Extension is likewise bundled with the agent jar, the same dropdown UI is used to enforce the user to pick the correct version.