Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gates doc for etcd #941

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Add feature gates doc for etcd #941

merged 10 commits into from
Jan 15, 2025
+84 −0

Conversation

gangli113
Copy link
Contributor

@gangli113 gangli113 commented Jan 7, 2025 •
edited
Loading

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangli113 gangli113 marked this pull request as draft January 7, 2025 00:41
@gangli113 gangli113 force-pushed the addFeatureGatesDoc branch 2 times, most recently from 4beeaa5 to c7d5a67 Compare January 7, 2025 19:04
@gangli113
Copy link
Contributor Author

/cc @siyuanfoundation

@gangli113 gangli113 marked this pull request as ready for review January 7, 2025 19:10
@gangli113 gangli113 force-pushed the addFeatureGatesDoc branch 2 times, most recently from eeca4bd to 1bb29ed Compare January 7, 2025 19:46
@siyuanfoundation
Copy link
Contributor

/lgtm Thanks @gangli113 !

/cc @serathius @ahrtr

@jmhbnz
Copy link
Member

jmhbnz commented Jan 8, 2025

/ok-to-test

spzala
spzala reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline review comment. Thanks!

@gangli113
Copy link
Contributor Author

/retest

@gangli113 gangli113 requested a review from spzala January 9, 2025 19:47
@gangli113 gangli113 requested a review from spzala January 10, 2025 18:25
spzala
spzala approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gangli113 thank you for addressing my comments! lgtm.

@siyuanfoundation
Copy link
Contributor

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz January 13, 2025 18:43
jmhbnz
jmhbnz requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gangli113 - Thanks for your work on this page. It's a great start, I have a few feedback items below.

content/en/docs/v3.6/feature-gates/index.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/feature-gates/index.md Show resolved Hide resolved
content/en/docs/v3.6/feature-gates/index.md Outdated Show resolved Hide resolved
gangli113 and others added 8 commits January 15, 2025 11:52
@gangli113
Add Feature gates docs for etcd
f41114c 
Signed-off-by: Gang Li <[email protected]>
@gangli113
fix text
c6b9b2b 
Signed-off-by: Gang Li <[email protected]>
@gangli113
fix shortcode "note"
b85aec3 
Signed-off-by: Gang Li <[email protected]>
@gangli113
Resolve comments
055ffd1 
Signed-off-by: Gang Li <[email protected]>
@gangli113
Remove DistributedTracing from feature gate list
f58a41d 
Signed-off-by: Gang Li <[email protected]>
@gangli113
use small cap etcd
3cf63e5 
fix markdown lint error

Signed-off-by: Gang Li <[email protected]>
@gangli113
use replace Etcd with etcd
e81bb9f 
Signed-off-by: Gang Li <[email protected]>
@gangli113 @jmhbnz
Update content/en/docs/v3.6/feature-gates/index.md
b9940bd 
Co-authored-by: James Blair <[email protected]>
Signed-off-by: Gang Li <[email protected]>
@gangli113 gangli113 requested a review from jmhbnz January 15, 2025 22:54
jmhbnz
jmhbnz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @gangli113

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gangli113, jmhbnz, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 6447d04 into etcd-io:main Jan 15, 2025
6 checks passed
@ivanvc ivanvc mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

@siyuanfoundation siyuanfoundation siyuanfoundation left review comments

@jmhbnz jmhbnz jmhbnz approved these changes

@spzala spzala spzala approved these changes

@serathius serathius Awaiting requested review from serathius

Assignees
No one assigned
Labels
approved ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gangli113 @k8s-ci-robot @siyuanfoundation @jmhbnz @spzala @ahrtr