Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid racing in closing Etcd.errc channel #19205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Avoid racing in closing Etcd.errc channel

7e815e9
Select commit
Loading
Failed to load commit list.
Open

Avoid racing in closing Etcd.errc channel #19205

Avoid racing in closing Etcd.errc channel
7e815e9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

68.75% (-0.08%) compared to 76d836f

View this Pull Request on Codecov

68.75% (-0.08%) compared to 76d836f

Details

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (76d836f) to head (7e815e9).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
server/embed/etcd.go 0.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/etcd.go 75.51% <0.00%> (-0.35%) ⬇️

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19205      +/-   ##
==========================================
- Coverage   68.83%   68.75%   -0.08%     
==========================================
  Files         420      420              
  Lines       35627    35629       +2     
==========================================
- Hits        24523    24496      -27     
- Misses       9683     9705      +22     
- Partials     1421     1428       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d836f...7e815e9. Read the comment docs.