Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct compaction period comments #19192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correct compaction period comments #19192

wants to merge 2 commits into from
+3 −3

Conversation

wodeyoulai
Copy link

As a new contributor getting familiar with the codebase for the first time, I noticed some inconsistencies in the comments describing the compaction period timing.

@wodeyoulai
docs: correct compaction period comments for 24-hour window
2f9cccb 
Update compaction period logic in periodic compactor to consistently
use 24-hour intervals instead of 1-hour. This fixes incorrect time
calculations where:
- Compaction period now correctly uses 24-hour instead of 1-hour
- Revision recording interval updated to 144-minute (1/10 of 24-hour)
  instead of 6-minute
- Retry interval on compaction failure adjusted to 144-minute to
  match the new period

This ensures consistent time-based compaction behavior for 24-hour
windows as originally intended.

Fixes #[issue-19017]
@wodeyoulai
docs: correct compaction period comments for 24-hour window
2c8efa6 
Update compaction period logic in periodic compactor to consistently
use 24-hour intervals instead of 1-hour. This fixes incorrect time
calculations where:
- Compaction period now correctly uses 24-hour instead of 1-hour
- Revision recording interval updated to 144-minute (1/10 of 24-hour)
  instead of 6-minute
- Retry interval on compaction failure adjusted to 144-minute to
  match the new period

This ensures consistent time-based compaction behavior for 24-hour
windows as originally intended.

Fixes #[issue-19017]
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wodeyoulai
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @wodeyoulai. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wodeyoulai
Copy link
Author

Related to #19017

@ahrtr
Copy link
Member

ahrtr commented Jan 16, 2025

Please signoff the commit,

git rebase HEAD~2 --signoff
git push --force-with-lease origin main

@wodeyoulai
Copy link
Author

Please signoff the commit,

git rebase HEAD~2 --signoff
git push --force-with-lease origin main

Thanks! I'll make the adjustments later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wodeyoulai @k8s-ci-robot @ahrtr