Fix the calculation of remaining bytes while sending snapshot to client.
#19116
Conversation
Signed-off-by: ishan16696 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ishan16696 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ishan16696. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## main #19116 +/- ##
==========================================
+ Coverage 68.76% 68.81% +0.04%
==========================================
Files 420 420
Lines 35640 35641 +1
==========================================
+ Hits 24508 24525 +17
+ Misses 9711 9690 -21
- Partials 1421 1426 +5 Continue to review full report in Codecov by Sentry.
|
| @@ -178,7 +179,7 @@ func (ms *maintenanceServer) Snapshot(sr *pb.SnapshotRequest, srv pb.Maintenance | |||
| // No, the client will still receive non-nil response | |||
| // until server closes the stream with EOF | |||
| resp := &pb.SnapshotResponse{ | |||
| RemainingBytes: uint64(total - sent), | |||
| RemainingBytes: uint64(totalByteToSend - sent), | |||
There was a problem hiding this comment.
ok, Can you please tell me where should I add the unit test for this as I don't see a test file of name : maintenance_test.go ?
Currently,
remaining bytesis only considering the size of database, not considering thesha256 sizeas it's also required to send. Please refer here for more info: #18340 (comment)This PR fixes the calculation of
remaining byteswhile sending snapshot to client. Moreover, it also improves the log to give more information.