Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] support custom content check offline in v2store #19113

Open
wants to merge 1 commit into
base: release-3.5
Choose a base branch
from
Open

[3.5] support custom content check offline in v2store #19113

wants to merge 1 commit into from

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Dec 28, 2024

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fuweid fuweid marked this pull request as ready for review December 28, 2024 23:11
@fuweid fuweid force-pushed the v35_offline_check_v2store branch from cd7a00f to cc7875b Compare December 28, 2024 23:12
ahrtr
ahrtr reviewed Dec 29, 2024
View reviewed changes
etcdutl/etcdutl/check_command.go Outdated Show resolved Hide resolved
tests/e2e/v2store_deprecation_test.go Outdated Show resolved Hide resolved
etcdutl/etcdutl/check_command.go Outdated Show resolved Hide resolved
@fuweid fuweid force-pushed the v35_offline_check_v2store branch from cc7875b to 6943150 Compare December 30, 2024 01:04
ahrtr
ahrtr reviewed Dec 30, 2024
View reviewed changes
etcdutl/etcdutl/check_command.go Show resolved Hide resolved
tests/e2e/v2store_deprecation_test.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Dec 30, 2024

Just raised two minor comments, overall looks good to me. Thanks @fuweid for the nice work!

@fuweid fuweid force-pushed the v35_offline_check_v2store branch from 6943150 to 5d284fd Compare December 30, 2024 20:27
ahrtr
ahrtr approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks.

Please also update the 3.5 changelog.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Dec 30, 2024

@ivanvc @jmhbnz I think it's time to release 3.5.18, of course after the holiday.

@ivanvc
Copy link
Member

ivanvc commented Dec 30, 2024

@ahrtr, I'll create the planning issue soon.

@ivanvc ivanvc mentioned this pull request Dec 31, 2024
Open
@ahrtr
Copy link
Member

ahrtr commented Dec 31, 2024

@ahrtr, I'll create the planning issue soon.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuweid @k8s-ci-robot @ahrtr @ivanvc