Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate distributed tracing flags off experimental prefix #19096

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

omerap12
Copy link

@omerap12 omerap12 commented Dec 22, 2024

Fixes: #19050
Move distributed tracing related flags:

  • experimental-enable-distributed-tracing
  • experimental-distributed-tracing-address
  • experimental-distributed-tracing-service-name
  • experimental-distributed-tracing-instance-id
  • experimental-distributed-tracing-sampling-rate

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @omerap12. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Member

/ok-to-test

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (e30a4ab) to head (a5e8b66).
Report is 14 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.65% <100.00%> (+0.22%) ⬆️
server/etcdmain/config.go 68.98% <100.00%> (+1.22%) ⬆️

... and 28 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19096   +/-   ##
=======================================
  Coverage   68.82%   68.82%           
=======================================
  Files         420      420           
  Lines       35640    35653   +13     
=======================================
+ Hits        24528    24538   +10     
- Misses       9692     9693    +1     
- Partials     1420     1422    +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30a4ab...a5e8b66. Read the comment docs.

Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12 omerap12 force-pushed the migrate-experiminal-enable-distributed-tracing branch from 36d8406 to a5e8b66 Compare December 31, 2024 12:51
@k8s-ci-robot
Copy link

@omerap12: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify a5e8b66 link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@omerap12
Copy link
Author

omerap12 commented Dec 31, 2024

Hey @serathius, I’m running into some issues with gofumpt 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

migrate --experimental-enable-distributed-tracing flag to feature gate
3 participants