-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate distributed tracing flags off experimental prefix #19096
base: main
Are you sure you want to change the base?
migrate distributed tracing flags off experimental prefix #19096
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @omerap12. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 28 files with indirect coverage changes @@ Coverage Diff @@
## main #19096 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 420 420
Lines 35640 35653 +13
=======================================
+ Hits 24528 24538 +10
- Misses 9692 9693 +1
- Partials 1420 1422 +2 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
36d8406
to
a5e8b66
Compare
@omerap12: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hey @serathius, I’m running into some issues with |
Fixes: #19050
Move distributed tracing related flags:
The experimental flags are marked as deprecated and will be decommissioned in v3.7.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.