Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated <-s.ReadyNotify() #19057

Merged
merged 1 commit into from
Dec 13, 2024

Remove duplicated <-s.ReadyNotify()

16ccfc9
Select commit
Loading
Failed to load commit list.
Merged

Remove duplicated <-s.ReadyNotify() #19057

Remove duplicated <-s.ReadyNotify()
16ccfc9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 13, 2024 in 0s

68.84% (+0.04%) compared to 026bbec

View this Pull Request on Codecov

68.84% (+0.04%) compared to 026bbec

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (026bbec) to head (16ccfc9).

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/serve.go 57.19% <ø> (-0.16%) ⬇️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19057      +/-   ##
==========================================
+ Coverage   68.79%   68.84%   +0.04%     
==========================================
  Files         420      420              
  Lines       35627    35626       -1     
==========================================
+ Hits        24509    24525      +16     
+ Misses       9688     9680       -8     
+ Partials     1430     1421       -9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026bbec...16ccfc9. Read the comment docs.