Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate experimental-compact-hash-check-enabled to feature gate. #19053

Merged
merged 1 commit into from
Dec 17, 2024

migrate experimental-compact-hash-check-enabled to feature gate.

85363bd
Select commit
Loading
Failed to load commit list.
Merged

migrate experimental-compact-hash-check-enabled to feature gate. #19053

migrate experimental-compact-hash-check-enabled to feature gate.
85363bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

68.75% (-0.07%) compared to b4450d5

View this Pull Request on Codecov

68.75% (-0.07%) compared to b4450d5

Details

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (b4450d5) to head (85363bd).

Files with missing lines Patch % Lines
server/embed/config.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
pkg/featuregate/feature_gate.go 87.66% <ø> (ø)
server/config/config.go 80.23% <ø> (ø)
server/embed/etcd.go 75.77% <100.00%> (-0.05%) ⬇️
server/etcdmain/config.go 67.76% <100.00%> (+1.09%) ⬆️
server/etcdserver/server.go 82.41% <100.00%> (-0.15%) ⬇️
server/features/etcd_features.go 60.00% <ø> (ø)
server/embed/config.go 79.46% <84.61%> (-0.03%) ⬇️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19053      +/-   ##
==========================================
- Coverage   68.82%   68.75%   -0.07%     
==========================================
  Files         420      420              
  Lines       35627    35640      +13     
==========================================
- Hits        24520    24505      -15     
- Misses       9679     9702      +23     
- Partials     1428     1433       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4450d5...85363bd. Read the comment docs.