Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Allow "v" prefix when specifying release version #19011

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Dec 5, 2024

This pull requests:

  1. Allows to specify the release version with either the "v" prefix or not (i.e., v3.6.0 or 3.6.0)
    2. Sets the BRANCH to main if the minor version is 3.6.

Technically, this is not needed if we pass the environment variable BRANCH set to main with every pre-release. So, another "fix" would be to document this in the release guide. I'm open to reverting and doing the documentation this way.

Part of #19010.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (2b32307) to head (e1e1787).
Report is 8 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19011      +/-   ##
==========================================
+ Coverage   68.78%   68.81%   +0.03%     
==========================================
  Files         420      420              
  Lines       35629    35623       -6     
==========================================
+ Hits        24506    24513       +7     
+ Misses       9700     9683      -17     
- Partials     1423     1427       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b32307...e1e1787. Read the comment docs.

scripts/release.sh Outdated Show resolved Hide resolved
scripts/release.sh Outdated Show resolved Hide resolved
The script currently fails if the version provided has the "v" prefix
(i.e., v3.6.0). Allow receiving the prefix and continue with the
process.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc force-pushed the fix-release-script-for-main-branch-releases branch from c85f070 to e1e1787 Compare December 5, 2024 23:27
@ivanvc ivanvc changed the title Fix release script for main branch releases release: Allow "v" prefix when specifying release version Dec 5, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 654495c into etcd-io:main Dec 6, 2024
35 checks passed
@ivanvc ivanvc deleted the fix-release-script-for-main-branch-releases branch December 6, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants