-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Allow "v" prefix when specifying release version #19011
release: Allow "v" prefix when specifying release version #19011
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19011 +/- ##
==========================================
+ Coverage 68.78% 68.81% +0.03%
==========================================
Files 420 420
Lines 35629 35623 -6
==========================================
+ Hits 24506 24513 +7
+ Misses 9700 9683 -17
- Partials 1423 1427 +4 Continue to review full report in Codecov by Sentry.
|
The script currently fails if the version provided has the "v" prefix (i.e., v3.6.0). Allow receiving the prefix and continue with the process. Signed-off-by: Ivan Valdes <[email protected]>
c85f070
to
e1e1787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull requests:
v3.6.0
or3.6.0
)2. Sets theBRANCH
to main if the minor version is3.6
.Technically, this is not needed if we pass the environment variableBRANCH
set tomain
with every pre-release. So, another "fix" would be to document this in the release guide. I'm open to reverting and doing the documentation this way.Part of #19010.