Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a separate in memory snapshot to reduce number of entries stored in raft memory storage #18825

Merged
merged 6 commits into from
Nov 29, 2024

Use assert in TestSnapshot tests

4989834
Select commit
Loading
Failed to load commit list.
Merged

Run a separate in memory snapshot to reduce number of entries stored in raft memory storage #18825

Use assert in TestSnapshot tests
4989834
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 29, 2024 in 0s

68.73% (-0.08%) compared to 8f91eb1

View this Pull Request on Codecov

68.73% (-0.08%) compared to 8f91eb1

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (8f91eb1) to head (4989834).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/server.go 87.23% 4 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/membership/cluster.go 88.53% <100.00%> (ø)
server/etcdserver/server.go 82.49% <87.23%> (+0.25%) ⬆️

... and 13 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18825      +/-   ##
==========================================
- Coverage   68.80%   68.73%   -0.08%     
==========================================
  Files         420      420              
  Lines       35575    35583       +8     
==========================================
- Hits        24479    24458      -21     
- Misses       9670     9696      +26     
- Partials     1426     1429       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f91eb1...4989834. Read the comment docs.