Add unit test for newClientCfg #13830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13830 +/- ##
==========================================
- Coverage 72.57% 72.47% -0.11%
==========================================
Files 467 467
Lines 38280 38282 +2
==========================================
- Hits 27781 27743 -38
- Misses 8722 8749 +27
- Partials 1777 1790 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ahrtr
force-pushed
the
add_ut_newClientCfg
branch
2 times, most recently
from
43f4ae0 to
7d2ca9b
Compare
serathius
reviewed
Mar 22, 2022
serathius
reviewed
Mar 22, 2022
serathius
reviewed
Mar 22, 2022
ahrtr
force-pushed
the
add_ut_newClientCfg
branch
from
7d2ca9b to
3780435
Compare
|
Resolved all comments. |
serathius
reviewed
Mar 22, 2022
| } | ||
| } | ||
|
|
||
| func TestNewClientConfigWithSecureCfg(t *testing.T) { |
There was a problem hiding this comment.
What is the reason this can be added as test case to above test?
There was a problem hiding this comment.
Because github.com/stretchr/testify/assert doesn't support comparing function, and tls.Config contains fields of function type if we provide Cert/Key/Cacert.
serathius
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a unit test for the original newClientCfg.
cc @serathius @spzala