Skip to content

Commit

Permalink
Addressed the review comments.
Browse files Browse the repository at this point in the history
Signed-off-by: ishan16696 <[email protected]>
  • Loading branch information
ishan16696 committed Dec 19, 2024
1 parent 7a9e65c commit d7c65f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions server/embed/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
features.DistributedTracing: false,
features.StopGRPCServiceOnDefrag: false,
features.InitialCorruptCheck: false,
features.TxnModeWriteWithSharedBuffer: false,
features.TxnModeWriteWithSharedBuffer: true,
},
},
{
Expand Down Expand Up @@ -159,7 +159,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
features.StopGRPCServiceOnDefrag: true,
features.DistributedTracing: false,
features.InitialCorruptCheck: false,
features.TxnModeWriteWithSharedBuffer: false,
features.TxnModeWriteWithSharedBuffer: true,
},
},
{
Expand All @@ -169,7 +169,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
features.StopGRPCServiceOnDefrag: false,
features.DistributedTracing: false,
features.InitialCorruptCheck: false,
features.TxnModeWriteWithSharedBuffer: false,
features.TxnModeWriteWithSharedBuffer: true,
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion server/features/etcd_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ var (
StopGRPCServiceOnDefrag: {Default: false, PreRelease: featuregate.Alpha},
InitialCorruptCheck: {Default: false, PreRelease: featuregate.Alpha},
CompactHashCheck: {Default: false, PreRelease: featuregate.Alpha},
TxnModeWriteWithSharedBuffer: {Default: false, PreRelease: featuregate.Alpha},
TxnModeWriteWithSharedBuffer: {Default: true, PreRelease: featuregate.Beta},
}
// ExperimentalFlagToFeatureMap is the map from the cmd line flags of experimental features
// to their corresponding feature gates.
Expand Down

0 comments on commit d7c65f9

Please sign in to comment.