Skip to content

Commit

Permalink
Add a caution note about making apply context bounded
Browse files Browse the repository at this point in the history
  • Loading branch information
shyamjvs committed Oct 3, 2024
1 parent c1976a6 commit 38a42c6
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions server/etcdserver/apply/uber_applier.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ func (a *uberApplier) Apply(r *pb.InternalRaftRequest) *Result {
// then dispatch() unpacks the request to a specific method (like Put),
// that gets executed down the hierarchy again:
// i.e. CorruptApplier.Put(CappedApplier.Put(...(BackendApplier.Put(...)))).
//
// CAUTION: The context below should NOT be changed to a bounded value without
// first addressing the risk of a transaction's operations being only partially
// applied when some operations timeout. More details here:
// https://github.com/etcd-io/etcd/issues/18667#issuecomment-2392286839
return a.applyV3.Apply(context.TODO(), r, a.dispatch)
}

Expand Down

0 comments on commit 38a42c6

Please sign in to comment.