Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit ckeditor.ready event instead of broadcasting and send instance #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trevordixon
Copy link

It seems to me (and certainly is so in my case) that it's more useful to $emit the ckeditor.ready event rather than $broadcast it so parent scopes hear about it instead of child scopes. For example, it allows me to use ng-if and still hear the event.

Also, it's useful to send a reference to the instance with the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant