-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rf_bridge.rst #4541
Open
zd3sf
wants to merge
8
commits into
esphome:current
Choose a base branch
from
zd3sf:patch-1
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update rf_bridge.rst #4541
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
16af21c
Update rf_bridge.rst
zd3sf 85d5ecd
Update rf_bridge.rst
zd3sf dfb2dd9
Update rf_bridge.rst
zd3sf 645683c
Update rf_bridge.rst
zd3sf c88557b
Merge branch 'current' into patch-1
zd3sf 07bf647
Merge branch 'current' into patch-1
zd3sf 44e60e4
Update rf_bridge.rst
zd3sf f5eaa06
Merge branch 'current' into patch-1
zd3sf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Clarify UART configuration to avoid ID confusion.
Based on the PR discussion, the
uart_id
is causing confusion. The example should be simplified and include a note about ID usage.uart: - id: uart_hub baud_rate: 19200 tx_pin: 1 rx_pin: 3 rf_bridge: id: kitchen_RF_bridge
Add this note after the configuration: