Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback images on site #680

Merged
merged 9 commits into from
Jan 6, 2025
Merged

fix: fallback images on site #680

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81293bb
fix: image sourced from github
Tanujkanti4441 Dec 21, 2024
d33888c
generate old avatar URLs
Tanujkanti4441 Dec 21, 2024
83da282
add utils.js and fallback images
Tanujkanti4441 Dec 30, 2024
f6193da
fix linting errors in utils.js
Tanujkanti4441 Dec 30, 2024
d1e5edf
fix styling error
Tanujkanti4441 Dec 30, 2024
13f3390
revert changes related to avatar link
Tanujkanti4441 Dec 31, 2024
6d75daf
revert changes in index and sponsors page
Tanujkanti4441 Jan 4, 2025
feb00fe
Merge branch 'main' into fix-image
Tanujkanti4441 Jan 4, 2025
91834de
fix CI errors
Tanujkanti4441 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/_includes/components/card.macro.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ <h3 class="card__title">
{{ params.teaser }}
</p>
<div class="card__footer">
<img class="blog-post__author-photo" src="{% if params.authorImage %}{{ params.authorImage }} {% else %}../../../assets/images/people/_placeholder-avatar.svg{% endif %}" alt="{{ params.authorName }}" width="40" height="40" loading="lazy">
{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}
<img class="blog-post__author-photo" src="{{ params.image if params.image else fallback_image }}" alt="{{ params.authorName }}" width="40" height="40" loading="lazy" onerror="this.src = '{{fallback_image}}'">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need the fallback changes.

We can see here a fallback image is already applied but actually it's not working, can it be considered as a bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that can be considered a bug. I just don't think we need to add fallback images to places where we didn't have them before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the fallback image was working as intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback images was only working for sponsors in All backers section as you can see in images provided in issue template of #679

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't think we need to add fallback images to places where we didn't have them before.

reverted the changes.

<div class="blog-post__author__details">
<div class="blog-post__author-name">{{ params.authorName }}</div>
<time class="blog-post__publish-date" datetime="{{ params.date }}">{{ params.date | readableDate }}</time>
Expand Down
3 changes: 2 additions & 1 deletion src/_includes/components/donation.macro.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
-->

{%- macro donationItem(params) -%}
{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}
<div class="donation">
<img class="donation__sponsor-logo" src="{{ params.image }}" width="40" height="40" alt="{{ params.name }}" onerror="this.src = '/assets/images/people/_placeholder-avatar.svg'" loading="lazy"/>
<img class="donation__sponsor-logo" src="{{ params.image if params.image else fallback_image }}" width="40" height="40" alt="{{ params.name }}" onerror="this.src = '{{fallback_image}}'" loading="lazy"/>

<div class="donation__content">
<p class="donation__sponsor-name">{{ params.name }}</p>
Expand Down
7 changes: 4 additions & 3 deletions src/_includes/components/profile.macro.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<!-- default profile -->
{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}
{%- macro member(params) -%}
<div class="profile profile--member">
<img class="profile__photo profile__photo--large" src="{% if params.photo %}{{ params.photo }} {% else %}../../../assets/images/people/_placeholder-avatar.svg{% endif %}" alt="{{ params.name }}" width="80" height="80">
<img class="profile__photo profile__photo--large" src="{{ params.image if params.image else fallback_image }}" alt="{{ params.name }}" width="80" height="80" onerror="this.src = '{{fallback_image}}'">
<div class="profile__details">
<div class="profile__name">
{{ params.name }}
Expand Down Expand Up @@ -75,7 +76,7 @@
<!-- has avatar, name, and handle only -->
{%- macro contributor(params) -%}
<div class="profile profile--contributor">
<img class="profile__photo profile__photo--medium" src="{% if params.photo %}{{ params.photo }} {% else %}../../../assets/images/people/_placeholder-avatar.svg{% endif %}" width="56" height="56" alt="{{ params.name }}" loading="lazy">
<img class="profile__photo profile__photo--medium" src="{{ params.image if params.image else fallback_image }}" width="56" height="56" alt="{{ params.name }}" loading="lazy" onerror="this.src = '{{fallback_image}}'">
<div class="profile__details">
<div class="profile__name">{{ params.name }}</div>
<a href="https://github.com/{{ params.handle}}" class="profile__handle">@{{ params.handle }}</a>
Expand All @@ -87,7 +88,7 @@
{%- macro post_author(params) -%}
<div class="profile profile--author">
<div class="profile--author__details">
<img class="profile__photo profile__photo--small" src="{% if params.photo %}{{ params.photo }} {% else %}../../../assets/images/people/_placeholder-avatar.svg{% endif %}" alt="{{ params.name }}" width="48" height="48" loading="lazy">
<img class="profile__photo profile__photo--small" src="{{ params.image if params.image else fallback_image }}" alt="{{ params.name }}" width="48" height="48" loading="lazy" onerror="this.src = '{{fallback_image}}'">
<div class="profile__details">
<div class="profile__name">
{{ params.name }}
Expand Down
7 changes: 5 additions & 2 deletions src/content/pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
{%- from 'components/donation.macro.html' import donationItem %}
{%- from 'components/card.macro.html' import card %}

{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}

<section class="section hero hero--homepage">
<div class="content-container grid">
<div class="span-1-7 content-container">
Expand Down Expand Up @@ -52,7 +54,8 @@ <h1 class="section-title">{{ site.homepage.title }}</h1>
<div class="sponsors">
{% for sponsor in top_sponsors %}
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{sponsor.image}}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{sponsor.name}}"
title="{{ sponsor.name }}" />
</a>
Expand Down Expand Up @@ -249,7 +252,7 @@ <h2 class="section-title h3">{{ site.homepage.sponsors.title }}</h2>
{% if sponsor.url %}
<a href="{{ sponsor.url }}" class="sponsor-link" rel="nofollow noopen sponsored" target="_blank">
{% endif %}
<img src="{{ sponsor.image }}" alt="{{ sponsor_title }}" title="{{ sponsor_title }}" height="48" loading="lazy" decoding="async" />
<img src="{{ sponsor.image if sponsor.image else fallback_image }}" alt="{{ sponsor_title }}" title="{{ sponsor_title }}" height="48" loading="lazy" decoding="async" onerror="this.src = '{{fallback_image}}'" />
{% if sponsor.url %}
</a>
{% endif %}
Expand Down
19 changes: 12 additions & 7 deletions src/content/pages/sponsors.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
{% set supporting_text = site.sponsors_page.description %}
{% set monthly_donations = sponsors.totals.monthlyDonations | dollars %}
{% set supporting_text = supporting_text | replace("BACKER_COUNT", sponsors.totals.sponsorCount) | replace("MONTHLY_DONATIONS", monthly_donations) %}
{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}

{{ hero({
title: site.sponsors_page.title,
Expand Down Expand Up @@ -42,7 +43,8 @@ <h2 class="section-title h4" id="diamond">{{ site.sponsors_page.tiers.diamond.ti

<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{ sponsor_title }}"
title="{{ sponsor_title }}" />
</a>
Expand All @@ -69,7 +71,8 @@ <h2 class="section-title h4" id="platinum">{{ site.sponsors_page.tiers.platinum.

<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{ sponsor_title }}"
title="{{ sponsor_title }}" />
</a>
Expand All @@ -96,7 +99,8 @@ <h2 class="section-title h4" id="gold">{{ site.sponsors_page.tiers.gold.title }}

<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{ sponsor_title }}"
title="{{ sponsor_title }}" />
</a>
Expand All @@ -123,7 +127,8 @@ <h2 class="section-title h4" id="silver">{{ site.sponsors_page.tiers.silver.titl

<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{ sponsor_title }}"
title="{{ sponsor_title }}" />
</a>
Expand All @@ -150,7 +155,8 @@ <h2 class="section-title h4" id="bronze">{{ site.sponsors_page.tiers.bronze.titl

<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" height="128"
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" height="128"
onerror="this.src = '{{fallback_image}}'"
alt="{{ sponsor_title }}"
title="{{ sponsor_title }}" />
</a>
Expand All @@ -174,7 +180,7 @@ <h2 class="section-title h4" id="technology">{{ site.sponsors_page.tiers.technol
{% set sponsor_title = site.sponsors_page.tech_sponsor_title | replace("SPONSOR_NAME", sponsor.name) | replace("TECH", sponsor.donation | capitalize) %}
<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
<img loading="lazy" decoding="async" src="{{ sponsor.image }}" alt="{{ sponsor_title }}" title="{{ sponsor_title }}" height="64"/>
<img loading="lazy" decoding="async" src="{{ sponsor.image if sponsor.image else fallback_image }}" alt="{{ sponsor_title }}" title="{{ sponsor_title }}" height="64" onerror="this.src = '{{fallback_image}}'"/>
</a>
</li>
{% endfor %}
Expand Down Expand Up @@ -222,7 +228,6 @@ <h2 class="section-title h3">{{ site.sponsors_page.tiers.backers.title }}</h2>
</div>
<div class="grid">
<ul role="list" class="sponsors span-1-12 sponsors--backers">
{% set fallback_image = '/assets/images/people/_placeholder-avatar.svg' %}
{% for sponsor in sponsors.backers %}
<li>
<a href="{{ sponsor.url | url }}" class="sponsor-link" rel="nofollow noopener sponsored" target="_blank">
Expand Down
Loading