feat: add config "flat/all" #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
commented
Dec 23, 2024
| @@ -17,7 +17,7 @@ module.exports = { | |||
| type: "suggestion", | |||
| docs: { | |||
| description: "disallow the use of `process.exit()`", | |||
| recommended: false, | |||
| recommended: true, | |||
There was a problem hiding this comment.
seems it's a bug: it was false, but was enabled in the recommended config
aladdin-add
force-pushed
the
feat/all-config
branch
3 times, most recently
from
6acee02 to
1d59eae
Compare
aladdin-add
commented
Dec 23, 2024
lib/configs/_commons.js
Outdated
| const rule = rules[ruleName] | ||
|
|
||
| // only add rules that are not deprecated | ||
| if (rule?.meta?.deprecated !== true) { |
There was a problem hiding this comment.
the ?. is only to make tsc happy. 😂
There was a problem hiding this comment.
You can try using Object.entries instead which removes the need for the look and makes the compiler happy.
eg. for(const [ruleName, rule] of Object.entries(rules) { ... }
aladdin-add
force-pushed
the
feat/all-config
branch
3 times, most recently
from
164bb72 to
cb4be05
Compare
open questions: 1. need to add an equivalent eslintrc config? fixes #400
aladdin-add
force-pushed
the
feat/all-config
branch
from
cb4be05 to
2e13d59
Compare
voxpelli
requested changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open questions:
2. need to add language options?fixes #400