Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Composer Glow Up / Changed Functionality #1513

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Chat Composer Glow Up / Changed Functionality #1513

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
54026ef
progress
technoplato Jan 10, 2025
952b479
Merge branch 'main' into ml/group-composer-glowup
technoplato Jan 13, 2025
db9553b
dm flow working with new dm and existing dm
technoplato Jan 13, 2025
cc44c63
first ugly draft
technoplato Jan 13, 2025
f78c3bb
some cleanup
technoplato Jan 13, 2025
8102c02
typescript/lint error fixes
technoplato Jan 13, 2025
1728c8c
chips are in
technoplato Jan 14, 2025
b6419ad
progress
technoplato Jan 14, 2025
99e3525
progress on search results list/todo list
technoplato Jan 14, 2025
a3d0d83
designs
technoplato Jan 14, 2025
55814f5
fix group name
technoplato Jan 14, 2025
4a9fb97
whoopsie
technoplato Jan 14, 2025
9517160
typescript navigation errors
technoplato Jan 14, 2025
5b29a45
remove hard coded input
technoplato Jan 14, 2025
ea59bf7
remove log
technoplato Jan 14, 2025
cd458c7
ignore noisy logs
technoplato Jan 14, 2025
39474b6
Merge branch 'main' into ml/group-composer-glowup
technoplato Jan 14, 2025
f4824a4
yarn clean; bandaid android notification crash
technoplato Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/ClickableText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ParsedText } from "@components/ParsedText/ParsedText";
import Clipboard from "@react-native-clipboard/clipboard";
import { actionSheetColors } from "@styles/colors";
import * as Linking from "expo-linking";
import { useCallback } from "react";
import { useCallback, useEffect } from "react";
import { StyleProp, StyleSheet, TextStyle, useColorScheme } from "react-native";
import { navigate } from "../utils/navigation";
import {
Expand All @@ -26,6 +26,10 @@ export function ClickableText({ children, style }: Props) {
const colorScheme = useColorScheme();
const styles = useStyles();

useEffect(() => {
console.log("ClickableText", children);
}, [children]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove debug logging before production deployment.

The useEffect hook with console.log should be removed before deploying to production as it may impact performance and pollute logs.

-  useEffect(() => {
-    console.log("ClickableText", children);
-  }, [children]);


const handleEmailPress = useCallback((email: string) => {
try {
Linking.openURL(`mailto:${email}`);
Expand All @@ -38,7 +42,7 @@ export function ClickableText({ children, style }: Props) {
}, []);

const handleNewConversationPress = useCallback((peer: string) => {
navigate("NewConversation", { peer });
navigate("Conversation", { peer });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Navigation route inconsistency detected

The change to use "Conversation" in ClickableText.tsx aligns with the majority of navigation patterns in the codebase. However, there is still one instance using the old "NewConversation" route:

  • features/conversation-list/conversation-list.screen.tsx:350: navigation.navigate("NewConversation", {});
🔗 Analysis chain

Verify navigation flow changes.

The navigation destination has changed from "NewConversation" to "Conversation". Ensure this change is intentional and all related navigation flows have been updated accordingly.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old navigation route
rg '"NewConversation"' --type ts --type tsx

# Search for navigation.navigate calls to verify consistency
ast-grep --pattern 'navigate("Conversation"'

Length of output: 120

Script:

#!/bin/bash
# Search for both old and new navigation routes
rg -t typescript -t javascriptreact -t typescriptreact '"NewConversation"|"Conversation"'

# Search for navigation patterns using ast-grep
ast-grep --pattern 'navigate($ROUTE, $$$)'

# Also search for navigation.navigate pattern
ast-grep --pattern 'navigation.navigate($ROUTE, $$$)'

Length of output: 4641

}, []);

const showCopyActionSheet = useCallback(
Expand Down
66 changes: 0 additions & 66 deletions components/Onboarding/WarpcastConnect.tsx
View file
Open in desktop

This file was deleted.

212 changes: 0 additions & 212 deletions components/Recommendations/Recommendation.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading