Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 Addon #111

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,21 @@
"npm-run-all"
]
},
{
// changing engines forces other people to need to upgrade their minimum node
// therefor engine changes are breaking changes
"depTypeList": ["engines"],
"enabled": false
},
{
// changing peerDependencies *at all* is a breaking change
"matchDepTypes": ["peerDependencies"],
"enabled": false
},
{
// changing engines forces other people to need to upgrade their minimum node
// therefor engine changes are breaking changes
"depTypeList": ["engines"],
"enabled": false

// keep ranges conservatively wide
"matchDepTypes": ["dependencies"],
"rangeStrategy": "update-lockfile"
}
]
}
51 changes: 25 additions & 26 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,17 @@ on:

env:
CI: true
CACHE_PATH: '**/node_modules'
LIBRARY_DIR: './polyfill'
TEST_DIR: './test-app'

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
tests:
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
name: Base Tests
timeout-minutes: 5
runs-on: ubuntu-latest
Expand All @@ -31,9 +39,11 @@ jobs:
- run: yarn install --frozen-lockfile

- name: Test with ${{ matrix.node }}
run: yarn ember test
run: node_modules/.bin/ember test
working-directory: ${{ env.TEST_DIR }}

floating-dependencies:
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
name: Floating Dependencies
timeout-minutes: 5
runs-on: ubuntu-latest
Expand All @@ -42,7 +52,6 @@ jobs:
node:
- "14"
- "16"

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
Expand All @@ -52,9 +61,11 @@ jobs:
- run: yarn install --no-lockfile

- name: Test with Node ${{ matrix.node }}
run: yarn ember test
run: node_modules/.bin/ember test
working-directory: ${{ env.TEST_DIR }}

try-scenarios:
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
name: "Compatibility"
timeout-minutes: 7
runs-on: ubuntu-latest
Expand All @@ -64,12 +75,12 @@ jobs:
fail-fast: true
matrix:
ember-try-scenario:
- ember-3.25
- ember-3.28-lts
- ember-3.27
- ember-3.28
- ember-4.0
- ember-release
- ember-beta
- ember-canary
- ember-could-get-used-to-this
- embroider-safe
- embroider-optimized
steps:
Expand All @@ -78,26 +89,13 @@ jobs:
with:
node-version: 14.x
- name: install dependencies
run: yarn install --frozen-lockfile
run: yarn install
- name: test
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup

ember-cli-update:
if: github.event_name == 'pull_request' && github.event.pusher.name == 'renovate-bot'
runs-on: ubuntu-latest
needs: [tests, try-scenarios, floating-dependencies]

steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.ECU_TOKEN }}
- uses: actions/setup-node@v2
- uses: kellyselden/ember-cli-update-action@v3
with:
autofix_command: yarn lint:fix
ignore_to: true

run: |
cd ${{ env.LIBRARY_DIR }}
yarn build
cd ../${{ env.TEST_DIR }}
yarn ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
publish:
name: Release
runs-on: ubuntu-latest
Expand All @@ -112,7 +110,8 @@ jobs:
- run: yarn install

- name: Release
run: yarn semantic-release
run: node_modules/.bin/semantic-release
working-directory: ${{ env.LIBRARY_DIR }}
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
88 changes: 0 additions & 88 deletions .github/workflows/lint.yml

This file was deleted.

137 changes: 137 additions & 0 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
name: Quality

on:
pull_request:
push:
# filtering branches here prevents duplicate builds from pull_request and push
branches:
- main
- master

env:
CI: true
CACHE_PATH: '**/node_modules'
LIBRARY_DIR: './polyfill'
TEST_DIR: './test-app'

concurrency:
group: quality-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
install_dependencies:
name: Install Dependencies
runs-on: ubuntu-latest
timeout-minutes: 15

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/[email protected]
with:
path: ${{ env.CACHE_PATH }}
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
restore-keys: "${{ runner.os }}-modules-"
- run: yarn install

source:
name: Source
runs-on: ubuntu-latest
needs: [install_dependencies]

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/[email protected]
with:
path: ${{ env.CACHE_PATH }}
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
- run: yarn install

- name: ESLint
run: |
cd ${{ env.LIBRARY_DIR }}
yarn lint:js

test_app:
name: Test App
runs-on: ubuntu-latest
needs: [install_dependencies]

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/[email protected]
with:
path: ${{ env.CACHE_PATH }}
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
- run: yarn install

- name: ESLint
run: |
cd ${{ env.TEST_DIR }}
yarn lint:js

- name: Type Checking
run: |
cd ${{ env.TEST_DIR }}
yarn tsc --build

tooling:
name: Tooling
runs-on: ubuntu-latest
needs: [install_dependencies]

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/[email protected]
with:
path: ${{ env.CACHE_PATH }}
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

- run: yarn install
- name: Semantic Release
run: |
cd ${{ env.LIBRARY_DIR }}
yarn semantic-release --dry-run
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# docs:
# if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
# name: Docs
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@v2
# - uses: volta-cli/action@v1

# - run: yarn install
# - run: yarn lint:docs


# docs-js-code:
# if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
# name: Docs (JS Code Samples)
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@v2
# - uses: volta-cli/action@v1

# - run: yarn install
# - run: yarn lint:docs-js

commits:
name: Commit Messages
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0

- uses: volta-cli/action@v1
- uses: wagoid/[email protected]
29 changes: 0 additions & 29 deletions .github/workflows/types.yml

This file was deleted.

Loading