feat(plugin): add bob launchpad to icp package. #714
+515
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-robert-ai
changed the title
odilitime
reviewed
Dec 10, 2024
| @@ -139,7 +167,7 @@ export const executeCreateToken: Action = { | |||
| website: response.website, | |||
| twitter: response.twitter, | |||
| telegram: response.telegram, | |||
| }); | |||
| }, 'launch-bob'); | |||
There was a problem hiding this comment.
why is this hard coded?
There was a problem hiding this comment.
launch.bob.fun is the most widely used launchpad on ICP, so it felt logical to set it as the default.
| twitter: unwrapOption(ok.twitter), | ||
| website: unwrapOption(ok.website), | ||
| telegram: unwrapOption(ok.telegram), | ||
| }), |
There was a problem hiding this comment.
why are these taken out in this branch?
|
@bob-robert-ai there are some conflicts with some other ICP-related create token functionality, would you mind reviewing that? |
Just fixed the conflicts, could you take a look? |
bob-robert-ai
force-pushed
the
icp-add-launch-bob-fun
branch
from
42d7c55 to
6dc98f8
Compare
wtfsayo
approved these changes
Jan 6, 2025
wtfsayo
requested changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add https://launch.bob.fun, the most popular launchpad platform on ICP to the ICP package.
Relates to:
Following this PR: #357
Risks
Low