Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor model config #1805

Merged
merged 22 commits into from
Jan 5, 2025
Merged

feat: refactor model config #1805

merged 22 commits into from
Jan 5, 2025

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Jan 4, 2025

related: #1655

(@monilpat should we update the model settings for each model in this PR?)

Implemented the separation of model configurations to enable model-specific settings instead of generalized ones across model providers.
Replaced hardcoded numbers with dynamic model setting data for better flexibility and maintainability.

@tcm390 tcm390 marked this pull request as draft January 4, 2025 06:43
@tcm390 tcm390 marked this pull request as ready for review January 5, 2025 14:29
@tcm390 tcm390 force-pushed the tcm-refactor-modelConfig branch from 68c316d to f3bfb38 Compare January 5, 2025 14:34
@tcm390 tcm390 changed the base branch from main to develop January 5, 2025 14:34
@tcm390 tcm390 requested a review from monilpat January 5, 2025 14:43
@odilitime odilitime changed the title refactor model config feat: refactor model config Jan 5, 2025
@shakkernerd shakkernerd merged commit 645dc9e into develop Jan 5, 2025
7 checks passed
@shakkernerd shakkernerd deleted the tcm-refactor-modelConfig branch January 5, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants