feat(twitter): allow leading numbers and wildcard in target usernames #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for elizaOS#1556 - Added support for Twitter usernames starting with numbers - Added support for wildcard '*' in TWITTER_TARGET_USERS - Fixed test discovery in test.sh to find all .test.ts files - Updated Jest config for better ESM support The main change allows Twitter target usernames to start with numbers and use wildcards, matching current Twitter/X username rules. Test infrastructure was improved to properly handle ESM modules and find all test files. Changes: - Updated username validation regex in Twitter client - Added test cases for numeric usernames and wildcards - Switched test.sh to use find for reliable test discovery - Simplified Jest config to focus on ESM support
|
Already implemented! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1556
The main change allows Twitter target usernames to start with numbers and use wildcards, matching current Twitter/X username rules. Test infrastructure was improved to properly handle ESM modules and find all test files.
Changes:
To run test added for this fix, run:
My discord username: hosermage