Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Romanian README translation #1770

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

pedronovikovborges
Copy link

Relates to:

Maintains original document structure and layout
Preserves all formatting, emojis, and technical terms
Retains all original links and image references
Includes full translation of all sections (Features, Use Cases, Quick Start, etc.)
Updates language selector in Translations section

Purpose:
🌍 This translation is part of our internationalization efforts to make Eliza more accessible to Romanian-speaking developers.

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@madjin madjin added the documentation Improvements or additions to documentation label Jan 4, 2025
Copy link
Collaborator

@madjin madjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

The Romanian translation of the README file covers most of the core content from the English version, but there are some differences in structure and additional sections. Here are the key points:

✅ The number of sections in the English and Romanian README files match, indicating the overall structure is similar.

✅ Key phrases and core content appear to be translated accurately in the Romanian version.

⚠️ However, the section titles and ordering don't match exactly between the two versions.

Section Differences

The Romanian README has sections that don't appear to have direct equivalents in the English version:

  • ## Rularea cu modele diferite (Running with different models)
  • ## Cerințe suplimentare (Additional requirements)
  • ## Telegram
  • ## Bot Discord
  • ## Teste (Tests)

These sections seem to provide more details on configuring and running the bot with different models, setting up specific clients like Telegram and Discord, and running tests.

On the other hand, the English README has some sections missing in the Romanian version:

  • ## 🌍 README Translations
  • ## Video Tutorials
  • ## 🚀 Quick Start
  • ## Contributors
  • ## Star History

So the Romanian version is missing information on alternate translations, video tutorials, a quick start guide, contributor info, and star history.

Some section titles that do overlap have different names:

  • ## ✨ Features (EN) vs ## Funcționalități (RO)
  • ## 🎯 Use Cases (EN) vs ## Pentru ce pot să-l folosesc? (RO)

Recommendations

To fully align the English and Romanian READMEs, consider the following:

  1. Add the additional technical sections from the Romanian version to the English README where appropriate, to cover those extra details.

  2. Translate the meta project info sections from the English version and add them to the Romanian README.

  3. Rename the overlapping sections to match between the two versions for consistency.

  4. Review the ordering of sections and adjust as needed so they follow the same logical flow in both versions.

Overall the translation looks good in terms of the core content, just needs some structural alignment. Let me know if you have any other questions or need further review!

odilitime
odilitime previously approved these changes Jan 5, 2025
@odilitime odilitime merged commit 9f4694f into elizaOS:develop Jan 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants