-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/plugin coingecko #1761
Feature/plugin coingecko #1761
Conversation
Duplicate/Related: #1382 |
^These are good additions, would like to also suggest the following to expand some useful use cases:
Onchain DEX data (requires pro-api key authentication)
|
someone who works in the |
that's cool |
#1808 was merged today; which is basic, you can work on this with more tailored functionality |
since we have this plugin #1808, we can think about centralizing all similar services, like In view of keeping the code clean and simple, at this point I would just remove the individual plugins, unifying them and using only this plugin ( which we can extend with the various features that the various let me know what you think @wtfsayo |
I think I would keep individual plugins and make a common that is limited to basic pricing features and can be use other plugins as fallback! Coingecko, CMC, DexScreener have different api capabilities afaik |
Just make sure it uses same envs as common plugin #1808 @Lukapetro and same for your cmc plugin please; remove conflicts and I will merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lets go
yeah it was duplicated, also when it was merged it was less functional then PR I was working on. |
hey @0xCardinalError, this could be partly my mistake, as I communicated with both of you and may not have coordinated things well. Yes, agree we are definitely building together 💪 let's chat more in TG. |
Hey @0xCardinalError thanks for the contribution! as other reviewers state, it might have been an overlook, though I had initially marked your PR (which at the time had more discussion/progress it seemed). With so many contributions coming in on the regular we reviewers sometimes have a tough time tracking progress across similar PRs. its definitely amazing how fast we are progressing, moving forward aim to improve communication between duplicate efforts more streamlined so no effort goes wasted. Even if cases like this happen, if the other PR has features which can be added on top of the merged contribution, let's add them to the merged feature! and yes we all are in this together 💪 |
yeah, all I can do now is check if there is something else I have that is not already merged and add it. I would say I hope its not going to happen again but I already see it here #1865 (comment) If this continues it will become toxic really fast. |
Feature/plugin coingecko
Risks
Low - This is an additive change that introduces a new plugin without modifying existing functionality. The main risks are:
CoinGecko API
Background
What does this PR do?
GET_PRICE
action that fetches current pricesWhat kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes require a change to the project documentation:
Testing
Where should a reviewer start?
/plugin-coingecko/src/
getPrice.ts
environment.ts
types.ts
Detailed testing steps
Set up environment:
Run agent locally and test natural language queries:
Verify error handling:
Future Expansion
Extended CoinGecko Integration:
Additional API Features:
/simple/supported_vs_currencies
- Add support for all available fiat currencies/coins/markets
- Include detailed market data/coins/{id}/tickers
- Add exchange-specific price data/coins/{id}/market_chart
- Support price charts and historical analysis/global
- Add global crypto market metrics/search
- Implement fuzzy search for coin names/exchange_rates
- Support BTC-to-fiat conversion rates/trending
- Add trending coins informationEnhanced Features:
Discord username
0xspit