-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ twitter Image Format Validation (#1694) #1756
Fix/ twitter Image Format Validation (#1694) #1756
Conversation
Client Twitter: - Modified base.ts and post.ts to handle image descriptions - Added comprehensive test suite with real images Plugin Node: - Enhanced image.ts with format validation - Added real image tests with multiple formats
not sure I like two copies of the same images, wonder if we should make a global directory for those |
I kept them separated because on 2 different packages. |
You want me to remove completely the tests here too ? |
@odilitime i fixed the conflics in the image.ts |
FYI - i replied to the AI Agent tweet with another user to give a picture and it failed now - A;lthought the text reply came. I see DallE was invoked to get image too. Received response from OpenAI model. ◎ LOGS ◎ LOGS ℹ INFORMATIONS ["◎ Generating new tweet"] ["◎ Matched fragment: promotes kriya yoga as a spiritual awakening tool thats better than your morning espressoinstant energy no caffeine jitters. with similarity: 0.6251623630523682"] ["◎ Matched fragment: represents the ideals of self-realization fellowship and the yoga sutras of patanjalithink ancient wisdom with a cosmic splash of sass. with similarity: 0.6848316192626953"] ["◎ Matched fragment: encourages the balance of meditation and actionbecause even enlightened beings cant skip leg day or laundry day. with similarity: 0.7110828757286072"] ["◎ Matched fragment: draws from the teachings of paramahansa yogananda author of autobiography of a yogi and patanjali the father of classical yogabecause the cosmos clearly loves a best-seller. with similarity: 0.7469132542610168"] ["◎ Matched fragment: teaches that life is a divine play urging you to ditch the drama and embrace the peaceunless youre auditioning for an oscar of course. with similarity: 0.7749838829040527"] ["◎ Generating text..."] ℹ INFORMATIONS ◎ LOGS ℹ INFORMATIONS ◎ LOGS ◎ LOGS ◎ LOGS /home/rchak007/github/AI-Agents/selfRealize/PullTests/eliza-pr-test1756/node_modules/solc/soljson.js:133 Error: {"errors":[{"code":38,"message":"media parameter is missing."}]} Node.js v23.3.0 Root Cause |
PR: Fix Image Format Validation (#1694)
Changes Made
Client Twitter Package
Enhanced Base Client (
base.ts
):Post Client (
post.ts
):Tests:
twitter-client-image.test.ts
)Plugin Node Package
Image Service (
image.ts
):Tests:
image.service.real.test.ts
)Testing
Notes