Add a screenshot button #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
reviewed
Aug 9, 2024
| try { | ||
| AppInfo.create_from_commandline ("io.elementary.screenshot", null, NONE).launch (null, null); | ||
| } catch (Error e) { | ||
| critical ("Failed to open system settings: %s", e.message); |
There was a problem hiding this comment.
Suggested change
| critical ("Failed to open system settings: %s", e.message); | |
| critical ("Failed to open Screenshot: %s", e.message); |
|
I'm not super convinced on this since screenshot is already available from the panel in the applications menu and can be pinned to the Dock. Unless there was like some new novel usage here or screenshot was for some reason not accessible as an app |
Yeah that's fair enough I kinda always forget about that since it's currently not that useful on touch (although I'm looking into changing that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will just launch the screenshot app.
TODO: add a symbolic icon