Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(plugin-vite): allow renderer name to contain dashes #3794

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

broose-goose
Copy link
Contributor

@broose-goose broose-goose commented Dec 30, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Small edit to vite plugin to allow VitePluginRendererConfig entries to have hyphens in their name.

Motivation is we have a large forge repo with multiple applications / frontends. We have them organized as follows:

.
└── src/
├── app-1-frontend-1
├── app-2-frontend-1
├── app-2-frontend-2
└── app-3-frontend-1

In forge v7.4.0, vite.base.config.ts was a part of the vite-typescript template. Ran into the issue while trying to update our dependencies as a result of #3583. This shouldn't break any existing users as if they already had "-" in their name, the build would've already been failing

@broose-goose broose-goose requested a review from a team as a code owner December 30, 2024 20:31
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but there is a nit

packages/plugin/vite/src/config/vite.base.config.ts Outdated Show resolved Hide resolved
@BlackHole1 BlackHole1 requested review from caoxiemeihao and a team December 31, 2024 16:18
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erickzhao erickzhao added this pull request to the merge queue Jan 2, 2025
Merged via the queue into electron:main with commit 2199fce Jan 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants