Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate index page of Deliverers, Shifts and Assignments #9

Open
wants to merge 10 commits into
base: filter_form
Choose a base branch
from
Open

Paginate index page of Deliverers, Shifts and Assignments #9

wants to merge 10 commits into from

Conversation

eldriclim
Copy link
Owner

@eldriclim eldriclim commented Jun 12, 2018 •
edited
Loading

https://trello.com/c/UjfHwCMk

Why is this change necessary?

  • May run out of memory when list of objects gets large
    • Eg, loading assignments which contains both Deliverers and Shifts info

How does it address the issue?

  • List of objects are segmented into pages and only loads upon call

Related PRs?

@coveralls
Copy link

coveralls commented Jun 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 93

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 91.928%
Totals Coverage Status
Change from base Build 90: 0.7%
Covered Lines: 205
Relevant Lines: 223
💛 - Coveralls

@eldriclim eldriclim requested a review from leanhdaovn June 12, 2018 06:14
@eldriclim eldriclim self-assigned this Jun 12, 2018
@eldriclim eldriclim added iteration-2 enhancement New feature or request labels Jun 12, 2018
@leanhdaovn leanhdaovn changed the base branch from master to filter_form June 16, 2018 10:21
leanhdaovn
leanhdaovn reviewed Jun 17, 2018
View reviewed changes
app/views/assignments/index.html.erb Outdated
<% end %>

<script type="text/javascript" >
$(function(){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wrapper function seems unnecessary

@leanhdaovn leanhdaovn changed the base branch from filter_form to master June 18, 2018 02:16
@leanhdaovn leanhdaovn changed the base branch from master to filter_form June 18, 2018 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanhdaovn leanhdaovn leanhdaovn approved these changes

Assignees

@eldriclim eldriclim

Labels
enhancement New feature or request iteration-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldriclim @coveralls @leanhdaovn