Send notification email upon assignment/unassignment #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 120
💛 - Coveralls |
leanhdaovn
reviewed
Jun 24, 2018
db/schema.rb
Outdated
| @@ -25,10 +25,11 @@ | |||
| create_table "deliverers", force: :cascade do |t| | |||
| t.string "name" | |||
| t.integer "vehicle" | |||
| t.integer "phone" | |||
| t.string "phone" | |||
There was a problem hiding this comment.
which migration converts this column to string?
There was a problem hiding this comment.
I have changed it back to t.integer as migration for this change is suppose to be in PR #8 which is yet to be merged.
I'm unsure why the change is retained only for this branch though, could it be anomaly in the schema auto-generation?
| @@ -8,6 +8,9 @@ class Deliverer < ApplicationRecord | |||
| validates :phone, presence: { message: 'Phone field is empty' }, | |||
| numericality: { only_integer: true, message: 'Phone has to be an integer' }, | |||
There was a problem hiding this comment.
is this validation still valid when the column type is changed to string?
There was a problem hiding this comment.
I am leaving it as it is for now since phone is now an integer
| @@ -0,0 +1,58 @@ | |||
| <h1> | |||
There was a problem hiding this comment.
where is this view used?
There was a problem hiding this comment.
Removed.
My bad, didn't remove when refractoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/SHmRJX2b
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Deploy Notes
Emailadded toDelivererPhone@email.com"app/mailershave been removed