Move all side effects to exported init function #25
+86
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m creating a package that uses yett under the hood and the way it requires an assigned whitelist/blacklist before the package is included makes it hard to use it with import/export because the load order can’t always be guaranteed. This pull request moves all immediate side-effects to an
init
function that’s exported along with the currentunblock
function. It still allows setting a whitelist/blacklist onwindow
but also accepts it as an argument to theinit
function.Usage before:
Usage after:
It would be a breaking change though because nothing will happen unless
init
is called. If that’s a problem there could perhaps be separate builds for browser and modules.Tests pass.