Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Add json_lines known issue to 8.16 release notes #16837

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Doc: Add json_lines known issue to 8.16 release notes #16837

merged 3 commits into from
Jan 6, 2025

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Dec 26, 2024 •
edited
Loading

@karenzone karenzone added the docs label Dec 26, 2024
@karenzone karenzone self-assigned this Dec 26, 2024
@karenzone karenzone marked this pull request as ready for review December 27, 2024 14:06
karenzone
karenzone commented Dec 27, 2024
View reviewed changes
Copy link
Contributor Author

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM. @robbavey, as we discussed, it seems weird to mention 8.17.0 in 8.16.x release notes. In this case, it makes sense to let users know that upgrading to 8.17 won't fix the issue because the problem is there, too.

@karenzone karenzone requested a review from robbavey December 27, 2024 20:53
@robbavey
Copy link
Member

robbavey commented Jan 2, 2025

I'm ok with 8.17.0 being mentioned here.

What do you think about beefing up the notable issues fixed entry for 8.16.2 for Reset internal size counter in BufferedTokenizer during flush to add a reference that this fixed the "Input buffer full" error?

@karenzone karenzone changed the title Doc: Add json_lines known issue to release notes Doc: Add json_lines known issue to 8.16 release notes Jan 3, 2025
@karenzone
Copy link
Contributor Author

@robbavey is this what you had in mind?

@robbavey
Copy link
Member

robbavey commented Jan 3, 2025

Yes, but WDYT about making it a link to known-issue-8-16-1-json_lines, instead of just text?

robbavey
robbavey approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit ed4b2e2 into elastic:8.16 Jan 6, 2025
5 checks passed
@karenzone karenzone deleted the 16822-ki-8.16 branch January 6, 2025 20:33
@karenzone
Copy link
Contributor Author

19780

@karenzone karenzone mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

Assignees

@karenzone karenzone

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenzone @robbavey