-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add example to cross-plugin-concepts #12672
Conversation
Adds an example showing users how to use the environment variable to define multiple whitespace-delimited URIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for expanding this section with a good example. I left a suggestion for minor wording tweaks inline.
Co-authored-by: Karen Metts <[email protected]>
This comment from yesterday was nested under an earlier review comment, and is easy to miss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion inline for your consideration. Please let me know if you would like to discuss.
Co-authored-by: Karen Metts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds an example showing users how to use the environment variable to define multiple whitespace-delimited URIs
What does this PR do?
Adds an example of how to use this functionality in an environment variable.
Why is it important/What is the impact to the user?
It is important because the current documentation is not clear enough and is confusing users as to how to use this behavior.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksRelated issues
Closes #12661