remove remaining idx usage #52354
Merged
remove remaining idx usage #52354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Pinging @elastic/ml-ui (:ml) |
spalger
added
release_note:skip
# Conflicts: # x-pack/legacy/plugins/infra/server/lib/adapters/fields/framework_fields_adapter.ts # x-pack/legacy/plugins/infra/server/lib/snapshot/snapshot.ts
|
@elasticmachine merge upstream |
|
Skipped flaky failing test #48721 |
jbudz
approved these changes
Dec 9, 2019
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Dec 9, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 9, 2019
* remove remaining idx usage * handle possibly undefined value * update NOTICE.txt # Conflicts: # x-pack/legacy/plugins/infra/server/lib/adapters/fields/framework_fields_adapter.ts # x-pack/legacy/plugins/infra/server/lib/snapshot/snapshot.ts
spalger
pushed a commit
that referenced
this pull request
Dec 10, 2019
* remove remaining idx usage * handle possibly undefined value * update NOTICE.txt # Conflicts: # x-pack/legacy/plugins/infra/server/lib/adapters/fields/framework_fields_adapter.ts # x-pack/legacy/plugins/infra/server/lib/snapshot/snapshot.ts
|
7.x/7.6: 19d426c |
simianhacker
added a commit
that referenced
this pull request
Dec 12, 2019
* Adding initial code for EC2 * Removing obsolute files; Adding EC2; * Removing currentTimerange and replacing it with currentTime; Timerange will now be calcuated on the server * Fixing AWS.s3 with Metrics Explorer * Auto calculating timerange and interval based on metricset.period * Adding S3 metricset * Inital addition of RDS metrics * Adding SQS and fixing a few things * Fixing typescript error * Adding RDS; Adjusting fields for S3; adding new formatter * Return 60 seconds by detault * Fixing types * Removing i18n * Fixing tests * Fixing translations * Fixes from merge * Removing IDX from code not covered by #52354 * fixing tests * Adding controls for crossliking; consolidating display name * remove obsolete import * Adding drop_last_bucket_support to TSVB models * Changing type * Fixing value per type * remvoing obsolete translation * Removing duplicate lines * Removing icons from switcher * Reducing boilerplate in Toolbar Items * Changing file name
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Dec 12, 2019
* Adding initial code for EC2 * Removing obsolute files; Adding EC2; * Removing currentTimerange and replacing it with currentTime; Timerange will now be calcuated on the server * Fixing AWS.s3 with Metrics Explorer * Auto calculating timerange and interval based on metricset.period * Adding S3 metricset * Inital addition of RDS metrics * Adding SQS and fixing a few things * Fixing typescript error * Adding RDS; Adjusting fields for S3; adding new formatter * Return 60 seconds by detault * Fixing types * Removing i18n * Fixing tests * Fixing translations * Fixes from merge * Removing IDX from code not covered by elastic#52354 * fixing tests * Adding controls for crossliking; consolidating display name * remove obsolete import * Adding drop_last_bucket_support to TSVB models * Changing type * Fixing value per type * remvoing obsolete translation * Removing duplicate lines * Removing icons from switcher * Reducing boilerplate in Toolbar Items * Changing file name
simianhacker
added a commit
that referenced
this pull request
Dec 13, 2019
* Adding initial code for EC2 * Removing obsolute files; Adding EC2; * Removing currentTimerange and replacing it with currentTime; Timerange will now be calcuated on the server * Fixing AWS.s3 with Metrics Explorer * Auto calculating timerange and interval based on metricset.period * Adding S3 metricset * Inital addition of RDS metrics * Adding SQS and fixing a few things * Fixing typescript error * Adding RDS; Adjusting fields for S3; adding new formatter * Return 60 seconds by detault * Fixing types * Removing i18n * Fixing tests * Fixing translations * Fixes from merge * Removing IDX from code not covered by #52354 * fixing tests * Adding controls for crossliking; consolidating display name * remove obsolete import * Adding drop_last_bucket_support to TSVB models * Changing type * Fixing value per type * remvoing obsolete translation * Removing duplicate lines * Removing icons from switcher * Reducing boilerplate in Toolbar Items * Changing file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idx()is blocking me in another PR, and is no longer necessary thanks to optional chaining enabled by the latest version of TypeScript, so this converts the last remaining usages of idx and removes the@kbn/elastic-idxpackage.