[Security Solution ] Fixes Timeline Unsaved changes badge color as per EUI recs
#207351
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
changed the title
Unsaved changes badge color as per EUI recs
logeekal
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
janmonschke
approved these changes
Jan 21, 2025
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
…per EUI recs (elastic#207351) ## Summary Handles - elastic#205733 ||Before|After| |---|---|---| |Light theme| <video src="https://github.com/user-attachments/assets/b8b89b2f-3c4f-40c1-b5b9-88a1044208cf" />| <video src="https://github.com/user-attachments/assets/33495309-c672-47c1-9f0d-e26892b62ef6" />| | Borealis Timeline Minimized | |  | | Borealis Timeline Maximized ( remains unchanged ) |  |  | (cherry picked from commit 089a91c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
…per EUI recs (elastic#207351) ## Summary Handles - elastic#205733 ||Before|After| |---|---|---| |Light theme| <video src="https://github.com/user-attachments/assets/b8b89b2f-3c4f-40c1-b5b9-88a1044208cf" />| <video src="https://github.com/user-attachments/assets/33495309-c672-47c1-9f0d-e26892b62ef6" />| | Borealis Timeline Minimized | |  | | Borealis Timeline Maximized ( remains unchanged ) |  |  |
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
… badge color as per EUI recs (#207351) (#207380) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution ] Fixes Timeline `Unsaved changes` badge color as per EUI recs (#207351)](#207351) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T15:02:56Z","message":"[Security Solution ] Fixes Timeline `Unsaved changes` badge color as per EUI recs (#207351)\n\n## Summary\n\nHandles\n- https://github.com/elastic/kibana/issues/205733\n\n||Before|After|\n|---|---|---|\n|Light theme| <video\nsrc=\"https://github.com/user-attachments/assets/b8b89b2f-3c4f-40c1-b5b9-88a1044208cf\"\n/>| <video\nsrc=\"https://github.com/user-attachments/assets/33495309-c672-47c1-9f0d-e26892b62ef6\"\n/>|\n| Borealis Timeline Minimized |\n|\n\n|\n| Borealis Timeline Maximized ( remains unchanged ) |\n\n|\n\n|","sha":"089a91c8287da8fc789e2144d778e7daddba44d1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:prev-minor"],"title":"[Security Solution ] Fixes Timeline `Unsaved changes` badge color as per EUI recs","number":207351,"url":"https://github.com/elastic/kibana/pull/207351","mergeCommit":{"message":"[Security Solution ] Fixes Timeline `Unsaved changes` badge color as per EUI recs (#207351)\n\n## Summary\n\nHandles\n- https://github.com/elastic/kibana/issues/205733\n\n||Before|After|\n|---|---|---|\n|Light theme| <video\nsrc=\"https://github.com/user-attachments/assets/b8b89b2f-3c4f-40c1-b5b9-88a1044208cf\"\n/>| <video\nsrc=\"https://github.com/user-attachments/assets/33495309-c672-47c1-9f0d-e26892b62ef6\"\n/>|\n| Borealis Timeline Minimized |\n|\n\n|\n| Borealis Timeline Maximized ( remains unchanged ) |\n\n|\n\n|","sha":"089a91c8287da8fc789e2144d778e7daddba44d1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207351","number":207351,"mergeCommit":{"message":"[Security Solution ] Fixes Timeline `Unsaved changes` badge color as per EUI recs (#207351)\n\n## Summary\n\nHandles\n- https://github.com/elastic/kibana/issues/205733\n\n||Before|After|\n|---|---|---|\n|Light theme| <video\nsrc=\"https://github.com/user-attachments/assets/b8b89b2f-3c4f-40c1-b5b9-88a1044208cf\"\n/>| <video\nsrc=\"https://github.com/user-attachments/assets/33495309-c672-47c1-9f0d-e26892b62ef6\"\n/>|\n| Borealis Timeline Minimized |\n|\n\n|\n| Borealis Timeline Maximized ( remains unchanged ) |\n\n|\n\n|","sha":"089a91c8287da8fc789e2144d778e7daddba44d1"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles
timeline_badge_before_fix.mp4
timeline_badge_color_fix.mp4