[Inventory] Fix Open Explore in Discover link in a new tab #207346
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmyz
added
release_note:fix
backport:prev-minor
|
/ci |
|
/ci |
jennypavlova
approved these changes
Jan 21, 2025
x-pack/solutions/observability/plugins/inventory/public/hooks/use_discover_redirect.ts
Outdated
Show resolved
Hide resolved
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @rmyz |
rmyz
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
…07346) ## Summary Closes elastic#207064 This PR fixes the Explore in Discover link to be able to open it in a new tab using `dataViewSpec: dataView.toMinimalSpec()`. ## How to test it 1. Enable `entityCentricExperience` feature flag 2. Run some synthtrace scenario, for example `node scripts/synthtrace infra_docker_containers` 3. Click into an entity group and select Explore in Discover in any entity. 4. You should be redirected to the data view correctly by clicking or opening in a new tab --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 131a543)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
…7346) (#207434) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Fix Open Explore in Discover link in a new tab (#207346)](#207346) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T19:54:55Z","message":"[Inventory] Fix Open Explore in Discover link in a new tab (#207346)\n\n## Summary\n\nCloses #207064\n\nThis PR fixes the Explore in Discover link to be able to open it in a\nnew tab using `dataViewSpec: dataView.toMinimalSpec()`.\n\n## How to test it\n1. Enable `entityCentricExperience` feature flag\n2. Run some synthtrace scenario, for example `node scripts/synthtrace\ninfra_docker_containers`\n3. Click into an entity group and select Explore in Discover in any\nentity.\n4. You should be redirected to the data view correctly by clicking or\nopening in a new tab\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"131a543eb280e45d3d4493da96e29fbd2e5df87c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[Inventory] Fix Open Explore in Discover link in a new tab","number":207346,"url":"https://github.com/elastic/kibana/pull/207346","mergeCommit":{"message":"[Inventory] Fix Open Explore in Discover link in a new tab (#207346)\n\n## Summary\n\nCloses #207064\n\nThis PR fixes the Explore in Discover link to be able to open it in a\nnew tab using `dataViewSpec: dataView.toMinimalSpec()`.\n\n## How to test it\n1. Enable `entityCentricExperience` feature flag\n2. Run some synthtrace scenario, for example `node scripts/synthtrace\ninfra_docker_containers`\n3. Click into an entity group and select Explore in Discover in any\nentity.\n4. You should be redirected to the data view correctly by clicking or\nopening in a new tab\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"131a543eb280e45d3d4493da96e29fbd2e5df87c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207346","number":207346,"mergeCommit":{"message":"[Inventory] Fix Open Explore in Discover link in a new tab (#207346)\n\n## Summary\n\nCloses #207064\n\nThis PR fixes the Explore in Discover link to be able to open it in a\nnew tab using `dataViewSpec: dataView.toMinimalSpec()`.\n\n## How to test it\n1. Enable `entityCentricExperience` feature flag\n2. Run some synthtrace scenario, for example `node scripts/synthtrace\ninfra_docker_containers`\n3. Click into an entity group and select Explore in Discover in any\nentity.\n4. You should be redirected to the data view correctly by clicking or\nopening in a new tab\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"131a543eb280e45d3d4493da96e29fbd2e5df87c"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #207064
This PR fixes the Explore in Discover link to be able to open it in a new tab using
dataViewSpec: dataView.toMinimalSpec().How to test it
entityCentricExperiencefeature flagnode scripts/synthtrace infra_docker_containers