-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components #207318
base: main
Are you sure you want to change the base?
[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components #207318
Conversation
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/kbn-babel-preset/styled_components_files.js
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
investigations changes LGTM, thank you!
@elasticmachine merge upstream |
There are no new commits on the base branch. |
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Summary
Addresses #206437
This PR migrates
explore page
fromstyled-components
to@emotion/styled
.In the process I also convert the kbn/ui-theme json tokens to euiTheme counterparts.
Screen.Recording.2025-01-21.at.11.22.34.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.