Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [EUI Refresh] [Explore page] Migrate styled-components #207318

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

agusruidiazgd
Copy link
Contributor

Summary

Addresses #206437
This PR migrates explore page from styled-components to @emotion/styled.
In the process I also convert the kbn/ui-theme json tokens to euiTheme counterparts.

Screen.Recording.2025-01-21.at.11.22.34.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Explore ci:cloud-deploy Create or update a Cloud deployment EUI Visual Refresh labels Jan 21, 2025
@agusruidiazgd agusruidiazgd self-assigned this Jan 21, 2025
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner January 21, 2025 10:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@agusruidiazgd agusruidiazgd added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Jan 21, 2025
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 21, 2025 10:39
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-babel-preset/styled_components_files.js LGTM

@agusruidiazgd agusruidiazgd requested a review from a team as a code owner January 22, 2025 11:28
Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

investigations changes LGTM, thank you!

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

There are no new commits on the base branch.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 23, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / arrows ArrowBody renders correctly against snapshot
  • [job] [logs] Jest Tests #2 / arrows ArrowBody renders correctly against snapshot
  • [job] [logs] Jest Tests #2 / Authentication Host Table Component rendering it renders the host authentication table
  • [job] [logs] Jest Tests #2 / Authentication Host Table Component rendering it renders the host authentication table
  • [job] [logs] Jest Tests #2 / Authentication User Table Component rendering it renders the user authentication table
  • [job] [logs] Jest Tests #2 / Authentication User Table Component rendering it renders the user authentication table
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call onChange when you choose a new sort in the table
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call onChange when you choose a new sort in the table
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call updateActivePage with 0 when you pick a new limit
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call updateActivePage with 0 when you pick a new limit
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events should call updateActivePage with 1 when clicking to the first page
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events should call updateActivePage with 1 when clicking to the first page
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call updateLimitPagination when you pick a new limit
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events Should call updateLimitPagination when you pick a new limit
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events should update the page when the activePage is changed from redux
  • [job] [logs] Jest Tests #2 / Paginated Table Component Events should update the page when the activePage is changed from redux
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it render popover to select new limit in table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it render popover to select new limit in table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the correct amount of pages and starts at activePage: 0
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the correct amount of pages and starts at activePage: 0
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the default load more table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the default load more table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the over loading panel after data has been in the table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it renders the over loading panel after data has been in the table
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering It should render a sort icon if sorting is defined
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering It should render a sort icon if sorting is defined
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it will NOT render popover to select new limit in table if props itemsPerRow is empty
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering it will NOT render popover to select new limit in table if props itemsPerRow is empty
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should display toast when user reaches end of results max
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should display toast when user reaches end of results max
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should hide items per row if totalCount is less than items
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should hide items per row if totalCount is less than items
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should hide pagination if totalCount is zero
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should hide pagination if totalCount is zero
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should show items per row if totalCount is greater than items
  • [job] [logs] Jest Tests #2 / Paginated Table Component rendering Should show items per row if totalCount is greater than items
  • [job] [logs] Jest Tests #2 / Paginated Table Component Toggle query toggleQuery updates toggleStatus
  • [job] [logs] Jest Tests #2 / Paginated Table Component Toggle query toggleQuery updates toggleStatus
  • [job] [logs] Jest Tests #2 / Paginated Table Component Toggle query toggleStatus=true, render table
  • [job] [logs] Jest Tests #2 / Paginated Table Component Toggle query toggleStatus=true, render table

History

cc @agusruidiazgd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants