Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Improve hover actions performance #207275

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 21, 2025

Closes #206686
Part of #207852

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 21, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) performance technical debt Improvement of the software architecture and operational architecture labels Jan 22, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 23, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #105 / machine learning - anomaly detection anomaly explorer with influencers with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case
  • [job] [logs] FTR Configs #105 / machine learning - anomaly detection anomaly explorer with influencers with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case
  • [job] [logs] FTR Configs #42 / security Has queryable API Keys should paginate keys

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationPanel 117 107 -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB -732.0B
dashboard 622.7KB 621.3KB -1.3KB
presentationPanel 48.1KB 36.5KB -11.7KB
total -13.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
presentationPanel 11.0KB 10.9KB -50.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
presentationPanel 7 6 -1

Total ESLint disabled count

id before after diff
presentationPanel 7 6 -1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Make hover actions more performant
2 participants