Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Removing App Search & Workplace Search deeplinks #206106

Merged

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Jan 9, 2025

Summary

This PR removes the deeplink for App Search & Workplace Search. This is a follow-up to #205634

Checklist

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Jan 9, 2025
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner January 9, 2025 16:43
@TattdCodeMonkey TattdCodeMonkey force-pushed the es-removal/as-ws-deeplinks branch from faf8b16 to c0a7335 Compare January 9, 2025 19:06
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner January 9, 2025 19:06
@TattdCodeMonkey TattdCodeMonkey force-pushed the es-removal/as-ws-deeplinks branch from 647d299 to 8e3ae1a Compare January 10, 2025 15:17
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/deeplinks-search 21 17 -4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 49.0KB 48.0KB -1.1KB
Unknown metric groups

API count

id before after diff
@kbn/deeplinks-search 21 17 -4

History

@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) January 13, 2025 14:50
@TattdCodeMonkey TattdCodeMonkey merged commit ec2fca1 into elastic:main Jan 13, 2025
8 checks passed
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 13, 2025
…6106)

## Summary

This PR removes the deeplink for App Search & Workplace Search. This is
a follow-up to elastic#205634

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…6106)

## Summary

This PR removes the deeplink for App Search & Workplace Search. This is
a follow-up to elastic#205634

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants