Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling UI, 9.0.0] Replace aggregation_field with aggregation_fields array #205861

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[Profiling UI, 9.0.0] Replace aggregation_field with aggregation_fields array #205861

merged 1 commit into from
Jan 8, 2025

Conversation

miloszmarcinkowski
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski commented Jan 8, 2025 •
edited
Loading

Summary

Replace aggregation_field with aggregation_fields to allow removal in ES v9.0.0

@miloszmarcinkowski miloszmarcinkowski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 8, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@miloszmarcinkowski miloszmarcinkowski marked this pull request as ready for review January 8, 2025 11:02
@miloszmarcinkowski miloszmarcinkowski requested a review from a team as a code owner January 8, 2025 11:02
rmyz
rmyz approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miloszmarcinkowski miloszmarcinkowski enabled auto-merge (squash) January 8, 2025 11:30
@miloszmarcinkowski miloszmarcinkowski merged commit 8365160 into elastic:main Jan 8, 2025
13 checks passed
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@miloszmarcinkowski @crespocarlos
[Profiling UI, 9.0.0] Replace aggregation_field with `aggregation_f…
bd4df96 
…ields` array (elastic#205861)

### Summary

Replace `aggregation_field` with `aggregation_fields` to allow removal
in ES v9.0.0
@rockdaboot rockdaboot mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmyz rmyz rmyz approved these changes

@Bluefinger Bluefinger Bluefinger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miloszmarcinkowski @elasticmachine @Bluefinger @rmyz @kibanamachine