[Discover] Fix issue where KEEP columns are not applied after Elasticsearch error
#205833
+34
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
release_note:fix
v9.0.0
Team:DataDiscovery
davismcphee
commented
Jan 8, 2025
Comment on lines
-65
to
-66
| }); | ||
| await this.retry.try(async () => { |
There was a problem hiding this comment.
This was failing while running my functional test because it tries to modify the Monaco editor after a refresh before it's initialized. I updated it to retry the whole update instead of just the check, and ran the FTR to be sure.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7666[✅] test/functional/apps/discover/esql/config.ts: 50/50 tests passed. |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @davismcphee |
kertal
approved these changes
Jan 8, 2025
tsullivan
approved these changes
Jan 8, 2025
|
Starting backport for target branches: 8.17, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
davismcphee
added a commit
to davismcphee/kibana
that referenced
this pull request
Jan 8, 2025
…icsearch error (elastic#205833) ## Summary This PR fixes an issue where columns are not applied correctly when using the ES|QL `KEEP` command after an Elasticsearch error has occurred. Fixes elastic#205353. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8eb326d) # Conflicts: # src/plugins/discover/public/application/main/hooks/use_esql_mode.ts # test/functional/services/monaco_editor.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where columns are not applied correctly when using the ES|QL
KEEPcommand after an Elasticsearch error has occurred.Fixes #205353.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelines