[Siem migrations] Onboarding UI changes #205734

semd · 2025-01-07T13:38:49Z

Summary

Minor fixes and enhancements

UI changes

Icon

Before

After

Connector step missing

Before

After

Flyout upload buttons added

Before

After

Rule migration result card collapsible

collapsible_results.mov

Other changes

Rule migration list order inverted to have more recent migrations first (same on the dropdown of translation rules table)
Rule migration result table fixes
Make retry logic inside of the start API route.
Fix results chart colors (Eui Borealis)

…ns/store_lookups

…ns/ui_changes

…changes

…ns/store_lookups

…ns/ui_changes

…changes

elasticmachine · 2025-01-15T11:38:08Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2025-01-15T11:38:10Z

Pinging @elastic/security-solution (Team: SecuritySolution)

e40pud

LGTM, thanks for the updates and fixes!

angorayc · 2025-01-15T17:33:14Z

nit: This might no to do with this change, just note the observation.
The selected connector is not aligned in the Configure AI Assistant card between Set up security and SIEM rule migration.

The one in the Set up security seemed not clickable. Hasn't checked on the main branch.

Screen.Recording.2025-01-15.at.17.26.04.mov

angorayc

Tested locally, LGTM! Thanks for the enhancement @semd 👍 👍 👍

angorayc · 2025-01-15T17:16:02Z

...ty/plugins/security_solution/public/siem_migrations/rules/utils/translation_results/index.ts

  return {
-    [RuleTranslationResult.FULL]: euiTheme.colors.vis.euiColorVis0,
-    [RuleTranslationResult.PARTIAL]: euiTheme.colors.vis.euiColorVis5,
-    [RuleTranslationResult.UNTRANSLATABLE]: euiTheme.colors.vis.euiColorVis7,
-    error: euiTheme.colors.vis.euiColorVis9,
+    [RuleTranslationResult.FULL]: euiTheme.colors.vis.euiColorVisSuccess0,
+    [RuleTranslationResult.PARTIAL]: euiTheme.colors.vis.euiColorSeverity7,
+    [RuleTranslationResult.UNTRANSLATABLE]: euiTheme.colors.vis.euiColorSeverity10,
+    error: euiTheme.colors.vis.euiColorSeverity14,


Just a heads up, the severity colors on Borealis theme might be updated again soon. Please follow the update here:
#206276 (comment)

Oh good to know. I think that's fine though, we'll update this again when colors change

angorayc · 2025-01-15T17:19:10Z

...n/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx

+const headerStyle = css`
+  &:hover {
+    cursor: pointer;
+    text-decoration: underline;
+  }
+`;


Could consider @emotion/react here given this is a new import.

Yup, I still have to change this default in my brain settings 🧠. changed here: 90d829a

angorayc · 2025-01-15T17:21:47Z

...s/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.tsx

+              ref={filePickerRef as React.Ref<Omit<EuiFilePickerProps, 'stylesMemoizer'>>}
+              fullWidth
+              initialPromptText={
+                <>


Is the fragment necessary here?

nope, this is a leftover from a previous version containing multiple elements. Changed in the 3 EuiFilePicker we are using here 90d829a

…changes' into siem_migrations/ui_changes

kibanamachine · 2025-01-15T20:38:58Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12796629124

elasticmachine · 2025-01-15T20:39:37Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: fbe7f7f

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #90 / machine learning - anomaly detection anomaly explorer with influencers with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	6521	6522	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	21.2MB	21.2MB	+11.1KB

Unknown metric groups

miscellaneous assets size

id	before	after	diff
`securitySolution`	5.6MB	5.6MB	-9.6KB

History

💚 Build #267339 succeeded 538f359

cc @semd

## Summary Minor fixes and enhancements ### UI changes #### Icon Before <img width="1166" alt="Captura de pantalla 2025-01-14 a les 19 33 25" src="https://github.com/user-attachments/assets/e651875e-92f1-40be-93da-e5c5b1fa8cd1" /> After <img width="1166" alt="Captura de pantalla 2025-01-14 a les 19 34 19" src="https://github.com/user-attachments/assets/017d2a95-6817-4949-b678-9d89d3b0ad90" /> #### Connector step missing Before <img width="1209" alt="Captura de pantalla 2025-01-14 a les 16 33 27" src="https://github.com/user-attachments/assets/55546bc9-4f99-490f-910c-26ec82749f7d" /> After <img width="1209" alt="Captura de pantalla 2025-01-14 a les 16 29 36" src="https://github.com/user-attachments/assets/9f3c50db-5f53-4ac9-8e41-a0e281b8115d" /> #### Flyout upload buttons added Before <img width="956" alt="Captura de pantalla 2025-01-14 a les 16 36 44" src="https://github.com/user-attachments/assets/b8111709-8bfe-4a03-baa7-576ca176feb3" /> After <img width="950" alt="Captura de pantalla 2025-01-14 a les 19 30 01" src="https://github.com/user-attachments/assets/afffb8b7-cf38-4f00-9142-2537bef394f3" /> #### Rule migration result card collapsible https://github.com/user-attachments/assets/4518510c-e215-4015-862b-07d90e38094b ### Other changes - Rule migration list order inverted to have more recent migrations first (same on the dropdown of translation rules table) - Rule migration result table fixes - Make `retry` logic inside of the `start` API route. - Fix results chart colors (Eui Borealis) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 8345223)

kibanamachine · 2025-01-15T20:44:13Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [[Siem migrations] Onboarding UI changes (#205734)](#205734)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Sergi Massaneda <[email protected]>

## Summary Minor fixes and enhancements ### UI changes #### Icon Before <img width="1166" alt="Captura de pantalla 2025-01-14 a les 19 33 25" src="https://github.com/user-attachments/assets/e651875e-92f1-40be-93da-e5c5b1fa8cd1" /> After <img width="1166" alt="Captura de pantalla 2025-01-14 a les 19 34 19" src="https://github.com/user-attachments/assets/017d2a95-6817-4949-b678-9d89d3b0ad90" /> #### Connector step missing Before <img width="1209" alt="Captura de pantalla 2025-01-14 a les 16 33 27" src="https://github.com/user-attachments/assets/55546bc9-4f99-490f-910c-26ec82749f7d" /> After <img width="1209" alt="Captura de pantalla 2025-01-14 a les 16 29 36" src="https://github.com/user-attachments/assets/9f3c50db-5f53-4ac9-8e41-a0e281b8115d" /> #### Flyout upload buttons added Before <img width="956" alt="Captura de pantalla 2025-01-14 a les 16 36 44" src="https://github.com/user-attachments/assets/b8111709-8bfe-4a03-baa7-576ca176feb3" /> After <img width="950" alt="Captura de pantalla 2025-01-14 a les 19 30 01" src="https://github.com/user-attachments/assets/afffb8b7-cf38-4f00-9142-2537bef394f3" /> #### Rule migration result card collapsible https://github.com/user-attachments/assets/4518510c-e215-4015-862b-07d90e38094b ### Other changes - Rule migration list order inverted to have more recent migrations first (same on the dropdown of translation rules table) - Rule migration result table fixes - Make `retry` logic inside of the `start` API route. - Fix results chart colors (Eui Borealis) --------- Co-authored-by: kibanamachine <[email protected]>

semd added 15 commits December 19, 2024 15:38

lookus saved as indices

ad9fd90

agent changes

82b1ae7

replace index pattern first

9cf2019

uncomment code

85221a5

Merge remote-tracking branch 'upstream/main' into 11435/siem_migratio…

4d5a41b

…ns/store_lookups

type fixes

f33fb45

fix test

eea5487

test fixed

f758e7d

translation agent improvements

cc221eb

Merge remote-tracking branch 'upstream/main' into 11435/siem_migratio…

be04b80

…ns/store_lookups

fix test

ef87075

Merge remote-tracking branch 'upstream/main' into 11435/siem_migratio…

71e67d4

…ns/store_lookups

Merge branch '11435/siem_migrations/store_lookups' into siem_migratio…

2c5e241

…ns/ui_changes

callapsible migration results panel

86c2a09

Merge remote-tracking branch 'upstream/main' into siem_migrations/ui_…

11d370d

…changes

semd self-assigned this Jan 7, 2025

semd added 8 commits January 8, 2025 15:52

Merge remote-tracking branch 'upstream/main' into 11435/siem_migratio…

85c3c07

…ns/store_lookups

Merge branch '11435/siem_migrations/store_lookups' into siem_migratio…

840cadc

…ns/ui_changes

resolve conflicts

cee4f09

unify retry and start API entpoints

893deb6

solve conflicts

46bd9ea

more conflicts solved

9bbb6a6

Merge remote-tracking branch 'upstream/main' into siem_migrations/ui_…

f51a1e5

…changes

add upload button

ab386b5

solve conflicts

9d35fd6

semd marked this pull request as ready for review January 15, 2025 11:38

semd requested review from a team as code owners January 15, 2025 11:38

[CI] Auto-commit changed files from 'yarn openapi:generate'

538f359

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 15, 2025 11:59

e40pud approved these changes Jan 15, 2025

View reviewed changes

angorayc approved these changes Jan 15, 2025

View reviewed changes

semd added 2 commits January 15, 2025 18:45

small changes

90d829a

Merge remote-tracking branch 'refs/remotes/origin/siem_migrations/ui_…

fbe7f7f

…changes' into siem_migrations/ui_changes

semd enabled auto-merge (squash) January 15, 2025 17:50

semd merged commit 8345223 into elastic:main Jan 15, 2025
8 checks passed

kibanamachine mentioned this pull request Jan 15, 2025

[8.x] [Siem migrations] Onboarding UI changes (#205734) #206863

Merged

semd mentioned this pull request Jan 16, 2025

[Rules migration] Improvements & fixes #206658

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Siem migrations] Onboarding UI changes #205734

[Siem migrations] Onboarding UI changes #205734

semd commented Jan 7, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Jan 15, 2025

elasticmachine commented Jan 15, 2025

e40pud left a comment

angorayc commented Jan 15, 2025

angorayc left a comment

angorayc Jan 15, 2025

semd Jan 15, 2025 •

edited

Loading

angorayc Jan 15, 2025

semd Jan 15, 2025

angorayc Jan 15, 2025

semd Jan 15, 2025

kibanamachine commented Jan 15, 2025

elasticmachine commented Jan 15, 2025

miscellaneous assets size

kibanamachine commented Jan 15, 2025

[Siem migrations] Onboarding UI changes #205734

[Siem migrations] Onboarding UI changes #205734

Conversation

semd commented Jan 7, 2025 • edited by kibanamachine Loading

Summary

UI changes

Icon

Connector step missing

Flyout upload buttons added

Rule migration result card collapsible

Other changes

elasticmachine commented Jan 15, 2025

elasticmachine commented Jan 15, 2025

e40pud left a comment

Choose a reason for hiding this comment

angorayc commented Jan 15, 2025

angorayc left a comment

Choose a reason for hiding this comment

angorayc Jan 15, 2025

Choose a reason for hiding this comment

semd Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

angorayc Jan 15, 2025

Choose a reason for hiding this comment

semd Jan 15, 2025

Choose a reason for hiding this comment

angorayc Jan 15, 2025

Choose a reason for hiding this comment

semd Jan 15, 2025

Choose a reason for hiding this comment

kibanamachine commented Jan 15, 2025

elasticmachine commented Jan 15, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

miscellaneous assets size

History

kibanamachine commented Jan 15, 2025

💚 All backports created successfully

Questions ?

semd commented Jan 7, 2025 •

edited by kibanamachine

Loading

semd Jan 15, 2025 •

edited

Loading