Search synonyms empty prompt #205723
Merged
Search synonyms empty prompt #205723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
efegurkan
added
release_note:skip
leemthompo
approved these changes
Jan 7, 2025
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/search_synonyms/public/components/empty_prompt/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
- Check config before registering - Update navigation on synonyms plugins - Fix missing config export - Fix quick check failures - FTR fixes - Review changes - [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' - Fix FTRs - Fix privilege FTR - Rebase and review changes Update tsconfig base path [CI] Auto-commit changed files from 'node scripts/generate codeowners' Fix types Fix checks Adds empty prompt Get started button is not functioning yet, and implemented as a placeholder. Fix rebase leftovers [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix'
efegurkan
force-pushed
the
search-synonyms-empty-prompt
branch
from
a7d467d to
0d99ded
Compare
Co-authored-by: Liam Thompson <[email protected]>
efegurkan
force-pushed
the
search-synonyms-empty-prompt
branch
from
ee4e847 to
9b3e6f5
Compare
…ibana into search-synonyms-empty-prompt
|
@efegurkan could you snap an updated screenshot if possible 🙏 😄 |
|
@leemthompo Updated the image above |
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
miscellaneous assets size
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
## Summary Implement empty prompt for the Synonyms page. <img width="1044" alt="Screenshot 2025-01-07 at 13 56 09" src="https://github.com/user-attachments/assets/d61c5251-afdb-4e34-bf18-a20ab1044800" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Liam Thompson <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5323067)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Search synonyms empty prompt (#205723)](#205723) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T17:06:29Z","message":"Search synonyms empty prompt (#205723)\n\n## Summary\r\n\r\nImplement empty prompt for the Synonyms page.\r\n\r\n<img width=\"1044\" alt=\"Screenshot 2025-01-07 at 13 56 09\"\r\nsrc=\"https://github.com/user-attachments/assets/d61c5251-afdb-4e34-bf18-a20ab1044800\"\r\n/>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"53230679065cd7bc00f15cdb01a3d7f592440c8f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.18.0"],"title":"Search synonyms empty prompt","number":205723,"url":"https://github.com/elastic/kibana/pull/205723","mergeCommit":{"message":"Search synonyms empty prompt (#205723)\n\n## Summary\r\n\r\nImplement empty prompt for the Synonyms page.\r\n\r\n<img width=\"1044\" alt=\"Screenshot 2025-01-07 at 13 56 09\"\r\nsrc=\"https://github.com/user-attachments/assets/d61c5251-afdb-4e34-bf18-a20ab1044800\"\r\n/>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"53230679065cd7bc00f15cdb01a3d7f592440c8f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205723","number":205723,"mergeCommit":{"message":"Search synonyms empty prompt (#205723)\n\n## Summary\r\n\r\nImplement empty prompt for the Synonyms page.\r\n\r\n<img width=\"1044\" alt=\"Screenshot 2025-01-07 at 13 56 09\"\r\nsrc=\"https://github.com/user-attachments/assets/d61c5251-afdb-4e34-bf18-a20ab1044800\"\r\n/>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"53230679065cd7bc00f15cdb01a3d7f592440c8f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Efe Gürkan YALAMAN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement empty prompt for the Synonyms page.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines