-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Improve messages for recovered alerts #205721
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/ml-ui (:ml) |
const count = response.length; | ||
const transformsString = response.map((t) => t.transform_id).join(', '); | ||
const count: number = isHealthy ? previousState?.unhealthy?.length ?? 0 : response.length; | ||
const transformsString = isHealthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, what about limiting the number of IDs we display in the first part of the message to say 10 (?), to say something like
35 transforms are not started: endpoint.metadata_current-default-8.18.0-prerelease.1, endpoint.metadata_united-default-8.18.0-prerelease.1, fq_continuous_latest_transform, fq_response_times_continuous, gallery_latest_transform, transform_a, transform_b, transform_c, transform_d, transform_e and 25 others
If a user really wants to see all the IDs they can loop through each of the IDs usinh the context variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in f36309a
...nsform/server/lib/alerting/transform_health_rule_type/register_transform_health_rule_type.ts
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @darnautov |
Summary
Updates the transform health alerting rules:
Checklist