Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Improve messages for recovered alerts #205721

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jan 7, 2025

Summary

Updates the transform health alerting rules:

  • Removes 100 limit
  • Changes format of the alert message
  • Mentions recovered transforms in the alert message

Checklist

@darnautov darnautov added :ml Feature:Transforms ML transforms v9.0.0 Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ML Team label for ML (also use :ml) backport:version Backport to applied version labels v8.18.0 labels Jan 7, 2025
@darnautov darnautov self-assigned this Jan 7, 2025
@darnautov darnautov requested a review from a team as a code owner January 7, 2025 12:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra changed the title [ML] Transforms: Imporove messages for recovered alerts [ML] Transforms: Improve messages for recovered alerts Jan 7, 2025
const count = response.length;
const transformsString = response.map((t) => t.transform_id).join(', ');
const count: number = isHealthy ? previousState?.unhealthy?.length ?? 0 : response.length;
const transformsString = isHealthy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, what about limiting the number of IDs we display in the first part of the message to say 10 (?), to say something like

35 transforms are not started: endpoint.metadata_current-default-8.18.0-prerelease.1, endpoint.metadata_united-default-8.18.0-prerelease.1, fq_continuous_latest_transform, fq_response_times_continuous, gallery_latest_transform, transform_a, transform_b, transform_c, transform_d, transform_e and 25 others

If a user really wants to see all the IDs they can loop through each of the IDs usinh the context variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in f36309a

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / useOnSubmit should set incremented name if other package policies exist

Metrics [docs]

✅ unchanged

History

cc @darnautov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Transforms ML transforms :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants