[Discover] Unskip functional discover request counts test and skip ES|QL part #205690
Conversation
kertal
added
release_note:skip
|
/ci |
| .getEntries() | ||
| .filter((entry: any) => ['fetch', 'xmlhttprequest'].includes(entry.initiatorType)) | ||
| ); | ||
| await retry.tryWithRetries( |
There was a problem hiding this comment.
I've rewrote this part, because it's simpler for debugging. when starting this test, going to get a coffee, tryWithRetries failes earlier than try. And it makes no sense here to wait too long
💚 Build Succeeded
Metrics [docs]
cc @kertal |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7652[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed. |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
| .filter((entry: any) => ['fetch', 'xmlhttprequest'].includes(entry.initiatorType)) | ||
| ); | ||
| await retry.tryWithRetries( | ||
| `expect ${type} request to match count ${searchCount}`, |
There was a problem hiding this comment.
| `expect ${type} request to match count ${searchCount}`, | |
| `expect ${type} request to match count ${searchCount}, but received ${count}`, |
Nit: If these fail in the future, the logs won't include the received count. Not a big deal, but could be worth defining count above so we can log it here.
There was a problem hiding this comment.
I think tryWithRetries works similar to try. it's using retryForSuccess under the hood:
and since the expect in the try function hasn't change, there should be no problem here?
I think it's waitFor that works differently?
kertal
added
the
backport:prev-minor
Summary
Resolves #205344
This PR is unskipping the main test, and unskipping the
ES|QLpart (for now, since it high likely needs to be rewritten to be unskipped, but we should not remove the code, even when skipped, it is valuable for testing)Checklist