-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [EUI Visual Refresh] update deprecated usage of "success" color #205679
Open
agusruidiazgd
wants to merge
6
commits into
elastic:main
Choose a base branch
from
agusruidiazgd:fix/eui-accent-secondary-issue-202491
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Security Solution] [EUI Visual Refresh] update deprecated usage of "success" color #205679
agusruidiazgd
wants to merge
6
commits into
elastic:main
from
agusruidiazgd:fix/eui-accent-secondary-issue-202491
+0
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusruidiazgd
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
v9.0.0
Team:Threat Hunting:Explore
EUI Visual Refresh
labels
Jan 7, 2025
agusruidiazgd
changed the title
eui visual refresh
[Security Solution] [EUI Visual Refresh] update deprecated usage of "success" color
Jan 7, 2025
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
@elasticmachine merge upstream |
mgadewoll
reviewed
Jan 7, 2025
...s/security/plugins/security_solution/public/common/components/header_page/editable_title.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
@elasticmachine merge upstream |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
January 7, 2025 15:18
jbudz
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/kbn-babel-preset/styled_components_files.js
LGTM
angorayc
approved these changes
Jan 7, 2025
⏳ Build in-progress, with failures
Failed CI Steps
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
EUI Visual Refresh
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Explore
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves EUI Visual Refresh issue #202491
This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replacing the deprecated color "success" colors have been updated to "accentSecondary".